Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove the tslint.json file #1987

Closed
wants to merge 1 commit into from

Conversation

mrazauskas
Copy link

@mrazauskas mrazauskas commented Feb 20, 2024

This PR removes the tslint.json file.

This file holds configuration / rules for tslint. It is not used after #1979. (Or?)

@@ -1,10 +0,0 @@
{
"extends": "dtslint/dtslint.json",
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Despite having dtslint in its name, this file simply holds a list of tslint rules, reference: https://github.com/microsoft/dtslint/blob/master/dtslint.json

@mrazauskas
Copy link
Author

Ah.. dtslint is using it. So this could be part of #1986 (or land as a follow up).

/cc @arnfaldur

@arnfaldur
Copy link

Indeed, removing the file has no effect on the test suite after the changes in #1986

@jdeniau jdeniau closed this Feb 23, 2024
@jdeniau
Copy link
Member

jdeniau commented Feb 23, 2024

Closing this, as it does not work.

@mrazauskas mrazauskas deleted the remove-tslint.json branch February 23, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants