Fix Repeat(<value>).equals(undefined) incorrectly returning true #1994
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like there was a mistake in this old commit, when
deepEqual
was switched from an inherited method to a helper function: 79e903b#diff-3ef08c64dab5fc92ebb8aecee330d5e7ae6cc8651f95aab2968b392c228dc606R103Note that this only happens when calling the
.equals
method directly.Immutable.is(Immutable.Repeat(<value>), undefined)
properly returns false, so this is a very minor issue that's unlikely to happen in practice. I only noticed this because I was looking at the immutable-js source code.