Fixes #1454 pass TypeMirrors to TypevarContext #1455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing the type arguments directly to TypevarContext means they don't have to be parsed, simplifying the code and avoiding the possibility of parse failures.
|
thank you for PR! Sorry for replying only now, I've seen the PR before, but didn't have any time to look into it. So, overall, I agree that it it might be a good change, however, I believe it was such arcane re-parsing was for a reason, it was a workaround for a series of problems with not properly reported generic information in old versions of compilers (somewhere during Java 1.6-1.8) and not yet-generated-types giving errors. It's possible that with current compilers these workarounds might not be necessary (actually, experimenting / prototyping Immutables 3 there's definitely an intention to all that trickery out). But I'm just hesitant to just making the change to not break some rare case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing the type arguments directly to TypevarContext means they don't have to be parsed, simplifying the code and avoiding the possibility of parse failures.
Any feedback is welcome. Please let me know if I can add or change anything here to better address the issue. In particular, I think it'd be better with test coverage, but I haven't found the best place to add that yet.