re-enable jdk9 collections support. #1481
Conversation
| @@ -27,7 +28,8 @@ | |||
| public class ObjectMappedTest { | |||
| private static final ObjectMapper OBJECT_MAPPER = new ObjectMapper(); | |||
| { | |||
| OBJECT_MAPPER.registerModule(new GuavaModule()); | |||
| OBJECT_MAPPER.registerModule(new GuavaModule()) | |||
| .enable(SerializationFeature.ORDER_MAP_ENTRIES_BY_KEYS); | |||
There was a problem hiding this comment.
To make serialization stable between JDK8 and JDK9+.
| check(coll.ints()).hasContentInAnyOrder(1, 2, 3, 4, 5, 6); | ||
| check(coll.navs()).hasContentInAnyOrder(3, 2, 1); | ||
| check(coll.ords()).hasContentInAnyOrder(4, 5, 6, 7, 8, 9); | ||
| check(coll.pols()).hasContentInAnyOrder(RetentionPolicy.RUNTIME); |
There was a problem hiding this comment.
To make comparisons stable between JDK8 and JDK9+.
isOf was taking verifying elements is exact order
|
Hang on, let me check something |
|
Good to go. 👍 |
SimY4
force-pushed
the
topic/re-enable-jdk9-collections
branch
from
5f673b7
to
b9df716
Compare
|
@elucash @asereda-gs may I bring your attention to this one? It re-enables JDK9 collections use. |
|
@SimY4 thank you for the PR! sorry for the late response, usual cycle of work/business-trip/in-the-bed-with-flu etc. While I think that we can re-enable JDK9 support (way overdue, right), it's still somewhat of a breaking change, unfortunately: those subtleties with |
No description provided.