Don't write file if content is identical #899
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@henrikno thank you for the PR! very clever solution. Sorry for the delay, I've seen this but only now got a chance to look into. So while I definitely see the benefits, the other side of this is that there should be an impact for any other usage (on this later) as reading the whole files and running them thru equals might have some performance impact that I'm yet to estimate. I'm interested to know the specifics of incremental compilation (was it just javac, or maven, gradle or something else). Is it possible to do this only when incremental compilation is executed? (I know this might be hard to answer) |
asereda-gs
force-pushed
the
master
branch
5 times, most recently
from
0840420
to
bf04627
Compare
asereda-gs
force-pushed
the
master
branch
2 times, most recently
from
82c6c1a
to
62a83d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed we were recompiling some modules even without doing any changes, and traced it back to files generated by immutables that changed the mtime of the files. This PR attempts to speed up incremental compiles by not writing the file if the content is already the same.