bugfix: sql.js v1.2+ don't support undefined parameters

before sql.js 1.2 it seems undefined were treated as if they were null, but as of 1.2 they cause a query error & fail to execute this change swaps out any undefined parameters with `null`s closes typeorm#5720
imnotjames · Sep 11, 2020 · d44b284 · d44b284
1 parent 7167903
commit d44b284
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -97,7 +97,7 @@
     "sinon": "^7.2.5",
     "sinon-chai": "^3.3.0",
     "source-map-support": "^0.5.10",
-    "sql.js": "^1.0.0",
+    "sql.js": "^1.3.0",
     "sqlite3": "^4.0.9",
     "ts-node": "^8.0.2",
     "typeorm-aurora-data-api-driver": "^1.3.0",

diff --git a/src/driver/sqljs/SqljsQueryRunner.ts b/src/driver/sqljs/SqljsQueryRunner.ts
@@ -53,6 +53,8 @@ export class SqljsQueryRunner extends AbstractSqliteQueryRunner {
             try {
                 statement = databaseConnection.prepare(query);
                 if (parameters) {
+                    parameters = parameters.map(p => typeof p !== 'undefined' ? p : null);
+
                     statement.bind(parameters);
                 }