Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Support multiple tsconfigs #22

Closed
wants to merge 5 commits into from

Conversation

teoxoy
Copy link
Contributor

@teoxoy teoxoy commented Aug 3, 2019

closes #21

Adds support for multiple tsconfigs.
This enables aliasing via compilerOptions.paths for monorepos with multiple tsconfigs
Should also improve performance because the mappers are cached.

Includes a new test and updated docs.
I have also tested the new changes in my own typescript monorepo and everything works as expected.

@teoxoy
Copy link
Contributor Author

teoxoy commented Aug 3, 2019

@teoxoy
Copy link
Contributor Author

teoxoy commented Aug 6, 2019

@bradzacher Can you take a look at this PR? It implements the same functionality as typescript-eslint/typescript-eslint#806
Thanks! :)

@fernandopasik
Copy link

fernandopasik commented Aug 13, 2019

Would it be possible to review this @alexgorbatchev or @bradzacher?

@JounQin
Copy link
Collaborator

JounQin commented Sep 10, 2019

Hi @teoxoy , it seems @alexgorbatchev has 'disappeared' for a few months, or he just forgot this project, so I'm going to fork this repository and republish it as eslint-import-resolver-ts to npm, I'm here to ask that are you will to make a separate PR to the new repository? Or can I cherry pick your commit into my repository?

@teoxoy
Copy link
Contributor Author

teoxoy commented Sep 10, 2019

@JounQin I think you can just merge it from upstream.

@JounQin
Copy link
Collaborator

JounQin commented Sep 10, 2019

@teoxoy Your PR has some conflicts with #20 what makes merging from upstream a bit painful.

@teoxoy
Copy link
Contributor Author

teoxoy commented Sep 10, 2019

I will start a PR on your fork then. Let me know when it's ready.

@JounQin
Copy link
Collaborator

JounQin commented Sep 10, 2019

@teoxoy It's already for a while, please try the repository link above.

@JounQin JounQin mentioned this pull request Sep 28, 2019
@JounQin JounQin closed this in #27 Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] Multiple tsconfig.json support
3 participants