Skip to content

Commit

Permalink
[Docs] order: fix bad inline config
Browse files Browse the repository at this point in the history
`alphabetize` option does not permit boolean
  • Loading branch information
nickofthyme authored and ljharb committed May 29, 2020
1 parent 3f46ccf commit 2e72af5
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 6 deletions.
11 changes: 7 additions & 4 deletions CHANGELOG.md
Expand Up @@ -21,6 +21,7 @@ This change log adheres to standards from [Keep a CHANGELOG](http://keepachangel
### Changed
- TypeScript config: Disable [`named`][] ([#1726], thanks [@astorije])
- [readme] Remove duplicate no-unused-modules from docs ([#1690], thanks [@arvigeus])
- [Docs] `order`: fix bad inline config ([#1788], thanks [@nickofthyme])

## [2.20.2] - 2020-03-28
### Fixed
Expand Down Expand Up @@ -676,11 +677,12 @@ for info on changes for earlier releases.

[`memo-parser`]: ./memo-parser/README.md

[#1770]: https://github.com/benmosher/eslint-plugin-import/issues/1770
[#1726]: https://github.com/benmosher/eslint-plugin-import/issues/1726
[#1724]: https://github.com/benmosher/eslint-plugin-import/issues/1724
[#1788]: https://github.com/benmosher/eslint-plugin-import/pull/1788
[#1770]: https://github.com/benmosher/eslint-plugin-import/pull/1770
[#1726]: https://github.com/benmosher/eslint-plugin-import/pull/1726
[#1724]: https://github.com/benmosher/eslint-plugin-import/pull/1724
[#1722]: https://github.com/benmosher/eslint-plugin-import/issues/1722
[#1719]: https://github.com/benmosher/eslint-plugin-import/issues/1719
[#1719]: https://github.com/benmosher/eslint-plugin-import/pull/1719
[#1702]: https://github.com/benmosher/eslint-plugin-import/issues/1702
[#1690]: https://github.com/benmosher/eslint-plugin-import/pull/1690
[#1681]: https://github.com/benmosher/eslint-plugin-import/pull/1681
Expand Down Expand Up @@ -1159,3 +1161,4 @@ for info on changes for earlier releases.
[@arvigeus]: https://github.com/arvigeus
[@atos1990]: https://github.com/atos1990
[@Hypnosphi]: https://github.com/Hypnosphi
[@nickofthyme]: https://github.com/nickofthyme
4 changes: 2 additions & 2 deletions docs/rules/order.md
Expand Up @@ -229,7 +229,7 @@ alphabetize: {
This will fail the rule check:

```js
/* eslint import/order: ["error", {"alphabetize": true}] */
/* eslint import/order: ["error", {"alphabetize": {"order": "asc", "caseInsensitive": true}}] */
import React, { PureComponent } from 'react';
import aTypes from 'prop-types';
import { compose, apply } from 'xcompose';
Expand All @@ -240,7 +240,7 @@ import blist from 'BList';
While this will pass:

```js
/* eslint import/order: ["error", {"alphabetize": true}] */
/* eslint import/order: ["error", {"alphabetize": {"order": "asc", "caseInsensitive": true}}] */
import blist from 'BList';
import * as classnames from 'classnames';
import aTypes from 'prop-types';
Expand Down

0 comments on commit 2e72af5

Please sign in to comment.