fix: imports should always use posix / http paths, even on win32

import-js · Feb 8, 2022 · 2ffc5bd · 2ffc5bd
1 parent e09468f
commit 2ffc5bd
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/src/rules/no-relative-packages.js b/src/rules/no-relative-packages.js
@@ -6,6 +6,12 @@ import moduleVisitor, { makeOptionsSchema } from 'eslint-module-utils/moduleVisi
 import importType from '../core/importType';
 import docsUrl from '../docsUrl';
 
+/** @type {(filePath: string) => string} */
+const toPosixPath =
+  path.sep === '\\'
+    ? (filePath) => filePath.replace(/\\/g, '/')
+    : (filePath) => filePath;
+
 function findNamedPackage(filePath) {
   const found = readPkgUp({ cwd: filePath });
   if (found.pkg && !found.pkg.name) {
@@ -42,7 +48,7 @@ function checkImportForRelativePackage(context, importPath, node) {
     context.report({
       node,
       message: `Relative import from another package is not allowed. Use \`${properImport}\` instead of \`${importPath}\``,
-      fix: fixer => fixer.replaceText(node, JSON.stringify(properImport))
+      fix: fixer => fixer.replaceText(node, JSON.stringify(toPosixPath(properImport)))
       ,
     });
   }

diff --git a/tests/src/rules/no-relative-packages.js b/tests/src/rules/no-relative-packages.js
@@ -67,7 +67,7 @@ ruleTester.run('no-relative-packages', rule, {
         line: 1,
         column: 17,
       } ],
-      output: `import foo from "${normalize('@scope/package-named')}"`,
+      output: `import foo from "@scope/package-named"`,
     }),
     test({
       code: 'import bar from "../bar"',
@@ -77,7 +77,7 @@ ruleTester.run('no-relative-packages', rule, {
         line: 1,
         column: 17,
       } ],
-      output: `import bar from "${normalize('eslint-plugin-import/tests/files/bar')}"`,
+      output: `import bar from "eslint-plugin-import/tests/files/bar"`,
     }),
   ],
 });