[Fix] order: Fix alphabetize bug with newlines-between

Fixes #1561.
import-js · Dec 9, 2019 · 614e55f · 614e55f
1 parent 2d669b1
commit 614e55f
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 4 deletions.
diff --git a/src/rules/order.js b/src/rules/order.js
@@ -599,16 +599,16 @@ module.exports = {
         registerNode(context, node, name, 'require', ranks, imported)
       },
       'Program:exit': function reportAndReset() {
+        if (newlinesBetweenImports !== 'ignore') {
+          makeNewlinesBetweenReport(context, imported, newlinesBetweenImports)
+        }
+
         if (alphabetize.order !== 'ignore') {
           mutateRanksToAlphabetize(imported, alphabetize.order)
         }
 
         makeOutOfOrderReport(context, imported)
 
-        if (newlinesBetweenImports !== 'ignore') {
-          makeNewlinesBetweenReport(context, imported, newlinesBetweenImports)
-        }
-
         imported = []
       },
       FunctionDeclaration: incrementLevel,

diff --git a/tests/src/rules/order.js b/tests/src/rules/order.js
@@ -560,6 +560,21 @@ ruleTester.run('order', rule, {
         alphabetize: {order: 'desc'},
       }],
     }),
+    // Option alphabetize with newlines-between: {order: 'asc', newlines-between: 'always'}
+    test({
+      code: `
+        import b from 'Bar';
+        import c from 'bar';
+        import a from 'foo';
+
+        import index from './';
+      `,
+      options: [{
+        groups: ['external', 'index'],
+        alphabetize: {order: 'asc'},
+        'newlines-between': 'always',
+      }],
+    }),
   ],
   invalid: [
     // builtin before external module (require)