Address PR feedback

import-js · Sep 28, 2021 · 70c0510 · 70c0510
1 parent a316041
commit 70c0510
Show file tree

Hide file tree

Showing 6 changed files with 43 additions and 58 deletions.
diff --git a/src/ExportMap.js b/src/ExportMap.js
@@ -1,5 +1,5 @@
 import fs from 'fs';
-import path from 'path';
+import { dirname } from 'path';
 
 import doctrine from 'doctrine';
 
@@ -517,6 +517,32 @@ ExportMap.parse = function (path, content, context) {
 
   const source = makeSourceCode(content, ast);
 
+  function readTsConfig() {
+    const tsConfigInfo = tsConfigLoader({
+      cwd:
+        (context.parserOptions && context.parserOptions.tsconfigRootDir) ||
+        process.cwd(),
+      getEnv: (key) => process.env[key],
+    });
+    try {
+      if (tsConfigInfo.tsConfigPath !== undefined) {
+        // Projects not using TypeScript won't have `typescript` installed.
+        if (!ts) (ts = require('typescript'));
+
+        const configFile = ts.readConfigFile(tsConfigInfo.tsConfigPath, ts.sys.readFile);
+        return ts.parseJsonConfigFileContent(
+          configFile.config,
+          ts.sys,
+          dirname(tsConfigInfo.tsConfigPath),
+        );
+      }
+    } catch (e) {
+      // Catch any errors
+    }
+
+    return null;
+  }  
+
   function isEsModuleInterop() {
     const cacheKey = hashObject({
       tsconfigRootDir: context.parserOptions && context.parserOptions.tsconfigRootDir,
@@ -763,32 +789,3 @@ function makeSourceCode(text, ast) {
     return new SourceCode({ text, ast });
   }
 }
-
-/**
- * Returns a project's TypeScript configuration.
- */
-export function readTsConfig(context) {
-  const tsConfigInfo = tsConfigLoader({
-    cwd:
-      (context.parserOptions && context.parserOptions.tsconfigRootDir) ||
-      process.cwd(),
-    getEnv: (key) => process.env[key],
-  });
-  try {
-    if (tsConfigInfo.tsConfigPath !== undefined) {
-      // Projects not using TypeScript won't have `typescript` installed.
-      if (!ts) (ts = require('typescript'));
-
-      const configFile = ts.readConfigFile(tsConfigInfo.tsConfigPath, ts.sys.readFile);
-      return ts.parseJsonConfigFileContent(
-        configFile.config,
-        ts.sys,
-        path.dirname(tsConfigInfo.tsConfigPath),
-      );
-    }
-  } catch (e) {
-    // Catch any errors
-  }
-
-  return null;
-}
diff --git a/tests/files/typescript-extended-config/index.d.ts b/tests/files/typescript-extended-config/index.d.ts
@@ -0,0 +1,3 @@
+export = FooBar;
+
+declare namespace FooBar {}
diff --git a/tests/files/typescript-extended-config/tsconfig.base.json b/tests/files/typescript-extended-config/tsconfig.base.json
@@ -1,8 +1,5 @@
 {
   "compilerOptions": {
-    "esModuleInterop": true,
-    "forceConsistentCasingInFileNames": true,
-    "skipLibCheck": true,
-    "strict": true
+    "esModuleInterop": true
   }
 }
diff --git a/tests/files/typescript-extended-config/tsconfig.json b/tests/files/typescript-extended-config/tsconfig.json
@@ -1,6 +1,4 @@
 {
   "extends": "./tsconfig.base.json",
-  "compilerOptions": {
-    "noEmit": true
-  }
+  "compilerOptions": {}
 }
diff --git a/tests/src/ExportMap.js b/tests/src/ExportMap.js
diff --git a/tests/src/rules/default.js b/tests/src/rules/default.js
@@ -231,6 +231,17 @@ context('TypeScript', function () {
             tsconfigRootDir: path.resolve(__dirname, '../../files/typescript-export-react-test-renderer/'),
           },
         }),
+        test({
+          code: `import Foo from "./typescript-extended-config"`,
+          parser,
+          settings: {
+            'import/parsers': { [parser]: ['.ts'] },
+            'import/resolver': { 'eslint-import-resolver-typescript': true },
+          },
+          parserOptions: {
+            tsconfigRootDir: path.resolve(__dirname, '../../files/typescript-extended-config/'),
+          },
+        }),
         test({
           code: `import foobar from "./typescript-export-assign-property"`,
           parser,