[Fix]: Conditionally run TS_NEW parser tests if defined

import-js · Mar 7, 2022 · ffd42e2 · ffd42e2
1 parent 85e6bc5
commit ffd42e2
Showing 1 changed file with 44 additions and 42 deletions.
diff --git a/tests/src/rules/no-cycle.js b/tests/src/rules/no-cycle.js
@@ -52,26 +52,6 @@ ruleTester.run('no-cycle', rule, {
     }),
 
     flatMap(testDialects, (testDialect) => [
-      test({
-        code: `function bar(){ return import("./${testDialect}/depth-one"); } // #2265 1`,
-        options: [{ allowUnsafeDynamicCyclicDependency: true }],
-        parser: parsers.BABEL_OLD,
-      }),
-      test({
-        code: `import { foo } from "./${testDialect}/depth-one-dynamic"; // #2265 2`,
-        options: [{ allowUnsafeDynamicCyclicDependency: true }],
-        parser: parsers.BABEL_OLD,
-      }),
-      test({
-        code: `function bar(){ return import("./${testDialect}/depth-one"); } // #2265 3`,
-        options: [{ allowUnsafeDynamicCyclicDependency: true }],
-        parser: parsers.TS_NEW,
-      }),
-      test({
-        code: `import { foo } from "./${testDialect}/depth-one-dynamic"; // #2265 4`,
-        options: [{ allowUnsafeDynamicCyclicDependency: true }],
-        parser: parsers.TS_NEW,
-      }),
       test({
         code: `import { foo } from "./${testDialect}/depth-two"`,
         options: [{ maxDepth: 1 }],
@@ -93,7 +73,28 @@ ruleTester.run('no-cycle', rule, {
         code: `import type { FooType, BarType } from "./${testDialect}/depth-one"`,
         parser: parsers.BABEL_OLD,
       }),
-    ]),
+      test({
+        code: `function bar(){ return import("./${testDialect}/depth-one"); } // #2265 1`,
+        options: [{ allowUnsafeDynamicCyclicDependency: true }],
+        parser: parsers.BABEL_OLD,
+      }),
+      test({
+        code: `import { foo } from "./${testDialect}/depth-one-dynamic"; // #2265 2`,
+        options: [{ allowUnsafeDynamicCyclicDependency: true }],
+        parser: parsers.BABEL_OLD,
+      }),
+    ].concat(parsers.TS_NEW ? [
+      test({
+        code: `function bar(){ return import("./${testDialect}/depth-one"); } // #2265 3`,
+        options: [{ allowUnsafeDynamicCyclicDependency: true }],
+        parser: parsers.TS_NEW,
+      }),
+      test({
+        code: `import { foo } from "./${testDialect}/depth-one-dynamic"; // #2265 4`,
+        options: [{ allowUnsafeDynamicCyclicDependency: true }],
+        parser: parsers.TS_NEW,
+      }),
+    ] : [])),
 
     test({
       code: 'import { bar } from "./flow-types"',
@@ -133,26 +134,6 @@ ruleTester.run('no-cycle', rule, {
     }),
 
     flatMap(testDialects, (testDialect) => [
-      test({
-        code: `function bar(){ return import("./${testDialect}/depth-one"); } // #2265 5`,
-        errors: [error(`Dependency cycle detected.`)],
-        parser: parsers.BABEL_OLD,
-      }),
-      test({
-        code: `import { foo } from "./${testDialect}/depth-one-dynamic"; // #2265 6`,
-        errors: [error(`Dependency cycle detected.`)],
-        parser: parsers.BABEL_OLD,
-      }),
-      test({
-        code: `function bar(){ return import("./${testDialect}/depth-one"); } // #2265 7`,
-        errors: [error(`Dependency cycle detected.`)],
-        parser: parsers.TS_NEW,
-      }),
-      test({
-        code: `import { foo } from "./${testDialect}/depth-one-dynamic"; // #2265 8`,
-        errors: [error(`Dependency cycle detected.`)],
-        parser: parsers.TS_NEW,
-      }),
       test({
         code: `import { foo } from "./${testDialect}/depth-one"`,
         errors: [error(`Dependency cycle detected.`)],
@@ -228,7 +209,28 @@ ruleTester.run('no-cycle', rule, {
         options: [{ maxDepth: '∞' }],
         errors: [error(`Dependency cycle via ./depth-one:1`)],
       }),
-    ]),
+      test({
+        code: `function bar(){ return import("./${testDialect}/depth-one"); } // #2265 5`,
+        errors: [error(`Dependency cycle detected.`)],
+        parser: parsers.BABEL_OLD,
+      }),
+      test({
+        code: `import { foo } from "./${testDialect}/depth-one-dynamic"; // #2265 6`,
+        errors: [error(`Dependency cycle detected.`)],
+        parser: parsers.BABEL_OLD,
+      }),
+    ].concat(parsers.TS_NEW ? [
+      test({
+        code: `function bar(){ return import("./${testDialect}/depth-one"); } // #2265 7`,
+        errors: [error(`Dependency cycle detected.`)],
+        parser: parsers.TS_NEW,
+      }),
+      test({
+        code: `import { foo } from "./${testDialect}/depth-one-dynamic"; // #2265 8`,
+        errors: [error(`Dependency cycle detected.`)],
+        parser: parsers.TS_NEW,
+      }),
+    ] : [])),
 
     test({
       code: 'import { bar } from "./flow-types-depth-one"',