Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for bundledDependencies #1438

Merged
merged 1 commit into from Sep 18, 2019
Merged

Add support for bundledDependencies #1438

merged 1 commit into from Sep 18, 2019

Conversation

schmidsi
Copy link
Contributor

@schmidsi schmidsi commented Aug 3, 2019 •
edited by ljharb

Fixes #1436

@coveralls
Copy link

coveralls commented Aug 3, 2019 •
edited

Coverage Status

Coverage increased (+0.05%) to 96.279% when pulling 5e143b2 on schmidsi:enhancement-bundledDependencies into 813a116 on benmosher:master.

@schmidsi schmidsi force-pushed the enhancement-bundledDependencies branch from 28a9547 to 352a424 Compare August 4, 2019 12:20
@schmidsi schmidsi marked this pull request as ready for review August 4, 2019 12:45
@schmidsi
Copy link
Contributor Author

schmidsi commented Aug 4, 2019

Fixes my original issue (prisma/prisma#314) through npm link. Should work now. Thanks for the help.

@ljharb ljharb changed the title WIP: Add support for bundledDependencies Add support for bundledDependencies Aug 5, 2019
ljharb
ljharb reviewed Aug 5, 2019
View reviewed changes
docs/rules/no-extraneous-dependencies.md Outdated Show resolved Hide resolved
src/rules/no-extraneous-dependencies.js Outdated Show resolved Hide resolved
@schmidsi schmidsi force-pushed the enhancement-bundledDependencies branch from 4868b89 to f9d47eb Compare August 8, 2019 08:28
schmidsi added a commit to schmidsi/eslint-plugin-import that referenced this pull request Aug 8, 2019
@schmidsi
More edge-case tests for bundledDependencies support import-js#1438
cb2bc76
@schmidsi
Copy link
Contributor Author

It's ready to merge in my opinion. Any more comments?

ljharb
ljharb requested changes Aug 17, 2019
View reviewed changes
src/rules/no-extraneous-dependencies.js Outdated Show resolved Hide resolved
src/rules/no-extraneous-dependencies.js Outdated Show resolved Hide resolved
@schmidsi
Copy link
Contributor Author

I think now it should be good to merge? 😊

@ljharb ljharb force-pushed the enhancement-bundledDependencies branch from a06cf2f to 5e143b2 Compare September 17, 2019 23:55
@ljharb ljharb merged commit 5e143b2 into import-js:master Sep 18, 2019
@schmidsi schmidsi deleted the enhancement-bundledDependencies branch September 18, 2019 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
semver-minor
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for bundledDependencies
3 participants
@schmidsi @coveralls @ljharb