add external modules setting (pick by package name) #1524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 similar comments
ValeryVS
force-pushed
the
add-external-modules-setting
branch
from
f3f9eca
to
4b06349
Compare
ValeryVS
changed the title
ljharb
reviewed
Dec 6, 2019
| @@ -341,6 +341,24 @@ Contribution of more such shared configs for other platforms are welcome! | |||
|
|
|||
| An array of folders. Resolved modules only from those folders will be considered as "external". By default - `["node_modules"]`. Makes sense if you have configured your path or webpack to handle your internal paths differently and want to considered modules from some folders, for example `bower_components` or `jspm_modules`, as "external". | |||
|
|
|||
| #### `import/external-modules` | |||
There was a problem hiding this comment.
https://github.com/benmosher/eslint-plugin-import#importexternal-module-folders already exists - how is this different?
| const folders = (settings && settings['import/external-module-folders']) || ['node_modules'] | ||
|
|
||
| // extract the part before the first / (redux-saga/effects => redux-saga) | ||
| const packageName = name.match(/([^/]+)/)[0] | ||
|
|
||
| return !path || folders.some(folder => -1 < path.indexOf(join(folder, packageName))) | ||
| return !path | ||
| || folders.some(folder => -1 < path.indexOf(join(folder, packageName))) |
There was a problem hiding this comment.
no need for a yoda condition, and "includes" exists:
Suggested change
| || folders.some(folder => -1 < path.indexOf(join(folder, packageName))) | |
| || folders.some(folder => path.includes(join(folder, packageName))) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1510