Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add eslint-plugin-eslint-plugin internally and fix violations #1620

Merged
merged 2 commits into from Jan 26, 2020
Merged

Add eslint-plugin-eslint-plugin internally and fix violations #1620

merged 2 commits into from Jan 26, 2020

Commits on Jan 20, 2020

  1. [Tests] add eslint-plugin-eslint-plugin internally and fix violations 

    This PR adds [eslint-plugin-eslint-plugin](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin) (a popular plugin for linting eslint plugins), enables relevant rules from it, and fixes violations.

The primary changes included are:
1. Adds missing rule schemas ([require-meta-schema](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/blob/master/docs/rules/require-meta-schema.md)). Note that `schema: []` is added to enforce when a rule should have no schema.
2. Adds missing rule `type` property to `no-unused-modules` rule ([require-meta-type](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/blob/master/docs/rules/require-meta-type.md)).
3. Removes duplicate test cases ([no-identical-tests](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/blob/master/docs/rules/no-identical-tests.md)).
    @bmish @ljharb
    bmish authored and ljharb committed Jan 20, 2020
    Copy the full SHA
    26f232b View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2020

  1. [Tests] only run the linter once, not on every build

    @ljharb
    ljharb committed Jan 26, 2020
    Copy the full SHA
    2d42464 View commit details
    Browse the repository at this point in the history