Set eslint-plugin/consistent-output lint rule to always require test case output assertions (internal only)
#1629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uire test case output assertions Use the more strict option for this internal lint rule. If a rule has no autofix, we should assert that there is no output. All of the test cases I fixed have no autofix, so the output matches the input. In eslint > v2, we can switch to `output: null` to represent this, and re-enable the `eslint-plugin/prefer-output-null` internal lint rule. https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/blob/master/docs/rules/consistent-output.md https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/blob/master/docs/rules/prefer-output-null.md
5 similar comments
bmish
force-pushed
the
consistent-output-always
branch
from
b3fff46
to
a5094cd
Compare
|
Unfortunately, it looks like this change fails in eslint v2. I believe that's because eslint v2 does not support We can reconsider this change when eslint v2 support is dropped. |
|
@bmish does it support repeating the input as the output? |
bmish
force-pushed
the
consistent-output-always
branch
from
a5094cd
to
08edc7f
Compare
|
@ljharb good point, I switched to repeating the input as the output. |
ljharb
approved these changes
Jan 27, 2020
ljharb
force-pushed
the
consistent-output-always
branch
from
08edc7f
to
6274d96
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the more strict option for this internal eslint-plugin/consistent-output lint rule. This will ensure that developers always assert what the autofixer output should be.
If a rule has no autofix, we should assert that there is no output. All of the test cases I fixed have no autofix, so the output matches the input. Once eslint v2 support is dropped, we can switch to
output: nullto represent this, and re-enable the eslint-plugin/prefer-output-null internal lint rule.Since this change is internal-only, I have not added it to the changelog.
Follow-up to #1620.