Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable import/named in the TypeScript configuration #1726

Merged
merged 1 commit into from Apr 13, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
Expand Up @@ -10,6 +10,9 @@ This change log adheres to standards from [Keep a CHANGELOG](http://keepachangel
- [`group-exports`]: Flow type export awareness ([#1702], thanks [@ernestostifano])
- [`order`]: Recognize pathGroup config for first group ([#1719], [#1724], thanks [@forivall], [@xpl])

### Changed
- TypeScript config: Disable [`named`][] ([#1726], thanks [@astorije])

## [2.20.2] - 2020-03-28
### Fixed
- [`order`]: fix `isExternalModule` detect on windows ([#1651], thanks [@fisker])
Expand Down Expand Up @@ -664,6 +667,7 @@ for info on changes for earlier releases.

[`memo-parser`]: ./memo-parser/README.md

[#1726]: https://github.com/benmosher/eslint-plugin-import/issues/1726
[#1724]: https://github.com/benmosher/eslint-plugin-import/issues/1724
[#1719]: https://github.com/benmosher/eslint-plugin-import/issues/1719
[#1702]: https://github.com/benmosher/eslint-plugin-import/issues/1702
Expand Down Expand Up @@ -1133,3 +1137,4 @@ for info on changes for earlier releases.
[@ernestostifano]: https://github.com/ernestostifano
[@forivall]: https://github.com/forivall
[@xpl]: https://github.com/xpl
[@astorije]: https://github.com/astorije
6 changes: 6 additions & 0 deletions config/typescript.js
Expand Up @@ -19,4 +19,10 @@ module.exports = {
},
},

rules: {
// analysis/correctness
ljharb marked this conversation as resolved.
Show resolved Hide resolved

// TypeScript compilation already ensures that named imports exist in the referenced module
'import/named': 'off',
},
}