Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] order: fix bad inline config #1788

Merged
merged 1 commit into from May 30, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 7 additions & 4 deletions CHANGELOG.md
Expand Up @@ -21,6 +21,7 @@ This change log adheres to standards from [Keep a CHANGELOG](http://keepachangel
### Changed
- TypeScript config: Disable [`named`][] ([#1726], thanks [@astorije])
- [readme] Remove duplicate no-unused-modules from docs ([#1690], thanks [@arvigeus])
- [Docs] `order`: fix bad inline config ([#1788], thanks [@nickofthyme])

## [2.20.2] - 2020-03-28
### Fixed
Expand Down Expand Up @@ -676,11 +677,12 @@ for info on changes for earlier releases.

[`memo-parser`]: ./memo-parser/README.md

[#1770]: https://github.com/benmosher/eslint-plugin-import/issues/1770
[#1726]: https://github.com/benmosher/eslint-plugin-import/issues/1726
[#1724]: https://github.com/benmosher/eslint-plugin-import/issues/1724
[#1788]: https://github.com/benmosher/eslint-plugin-import/pull/1788
[#1770]: https://github.com/benmosher/eslint-plugin-import/pull/1770
[#1726]: https://github.com/benmosher/eslint-plugin-import/pull/1726
[#1724]: https://github.com/benmosher/eslint-plugin-import/pull/1724
[#1722]: https://github.com/benmosher/eslint-plugin-import/issues/1722
[#1719]: https://github.com/benmosher/eslint-plugin-import/issues/1719
[#1719]: https://github.com/benmosher/eslint-plugin-import/pull/1719
[#1702]: https://github.com/benmosher/eslint-plugin-import/issues/1702
[#1690]: https://github.com/benmosher/eslint-plugin-import/pull/1690
[#1681]: https://github.com/benmosher/eslint-plugin-import/pull/1681
Expand Down Expand Up @@ -1159,3 +1161,4 @@ for info on changes for earlier releases.
[@arvigeus]: https://github.com/arvigeus
[@atos1990]: https://github.com/atos1990
[@Hypnosphi]: https://github.com/Hypnosphi
[@nickofthyme]: https://github.com/nickofthyme
4 changes: 2 additions & 2 deletions docs/rules/order.md
Expand Up @@ -229,7 +229,7 @@ alphabetize: {
This will fail the rule check:

```js
/* eslint import/order: ["error", {"alphabetize": true}] */
/* eslint import/order: ["error", {"alphabetize": {"order": "asc", "caseInsensitive": true}}] */
import React, { PureComponent } from 'react';
import aTypes from 'prop-types';
import { compose, apply } from 'xcompose';
Expand All @@ -240,7 +240,7 @@ import blist from 'BList';
While this will pass:

```js
/* eslint import/order: ["error", {"alphabetize": true}] */
/* eslint import/order: ["error", {"alphabetize": {"order": "asc", "caseInsensitive": true}}] */
import blist from 'BList';
import * as classnames from 'classnames';
import aTypes from 'prop-types';
Expand Down