Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] order: update the description of the pathGroupsExcludedImportTypes option #2239

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

liby
Copy link
Contributor

@liby liby commented Sep 28, 2021

Motivation: #2156

#1665 I read this issue and knowing why we had this PR, but I think they use pathGroupsExcludedImportTypes in the wrong way. If we need to let pathGroup works, sometimes we have to add pathGroupsExcludedImportTypes as [].

@Mairu @Akiq2016 @yola-0316 PTAL.

@codecov
Copy link

codecov bot commented Sep 28, 2021

Codecov Report

Merging #2239 (74450a3) into main (dd81424) will decrease coverage by 0.59%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2239      +/-   ##
==========================================
- Coverage   95.23%   94.63%   -0.60%     
==========================================
  Files          65       65              
  Lines        2686     2686              
  Branches      888      888              
==========================================
- Hits         2558     2542      -16     
- Misses        128      144      +16     
Impacted Files Coverage Δ
src/rules/no-unresolved.js 83.33% <0.00%> (-16.67%) ⬇️
utils/resolve.js 88.13% <0.00%> (-11.87%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd81424...74450a3. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant