[Deps] update eslint-module-utils

[slaweet]

Resolves #2255

What was the problem?

the file eslint-module-utils/visit didn't exist previously
https://github.com/import-js/eslint-plugin-import/tree/v2.24.2/utils/visit.js
it only exists in the latest minor version bump
https://github.com/import-js/eslint-plugin-import/blob/v2.25.0/utils/visit.js

[slaweet]

Looks like I cannot make the Require “Allow Edits” / Require “Allow Edits” (pull_request_target) check pass.
It doesn't show the checkbox for me as in the screenshot in the docs https://docs.github.com/en/github/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork

I see only this:

[Haprog]

@slaweet I think you need to click the "Edit" button at the top first to see the checkbox.

[slaweet]

@slaweet I think you need to click the "Edit" button at the top first to see the checkbox.

I have tried that, but but still no checkbox:

[paescuj]

@slaweet Thanks for your fix! You probably need to recreate this pull request and choose "Allow edits from maintainers" while creating.

[slaweet]

@slaweet Thanks for your fix! You probably need to recreate this pull request and choose "Allow edits from maintainers" while creating.

@paescuj thank you for the suggestion. I made another branch to try opening a new PR, but still no checkbox:

But now I'm looking that check is not marked as "Required". Is it really needed?

[paescuj]

@slaweet Huh, strange... Maybe this is prevented by a global setting in your account. However, IMO this check can be ignored - but that's up to the maintainers...

[ljharb]

@slaweet the issue is that you made a PR from a fork you don't own. Please never do that.

To resolve this, you'll need to add me to your fork.

Since PRs once opened permanently pollute a repo, I will not release a fix for this until I can force push to this PR, so this PR now blocks the release.

[paescuj]

@ljharb Thanks for your explanation!

Since PRs once opened permanently pollute a repo

Why is that?

[ljharb]

@paescuj because Github creates an origin/pull/2256 ref for this PR (and a similar one for every PR), and those refs can never be removed, only updated by updating a PR.

[paescuj]

@paescuj because Github creates an origin/pull/2256 ref for this PR (and a similar one for every PR), and those refs can never be removed, only updated by updating a PR.

Ah, I see! Thanks!

[ljharb]

@slaweet alternatively, you can git push origin 85739db0:2255-fix-eslint-module-utils-version -f (assuming origin is the fork in question) and it should properly update and auto-close this PR.

[codecov]

Codecov Report

Merging #2256 (c1334a6) into main (9cc1654) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2256   +/-   ##
=======================================
  Coverage   95.23%   95.23%           
=======================================
  Files          65       65           
  Lines        2686     2686           
  Branches      888      888           
=======================================
  Hits         2558     2558           
  Misses        128      128           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9cc1654...c1334a6. Read the comment docs.

[slaweet]

@slaweet the issue is that you made a PR from a fork you don't own. Please never do that.

@ljharb Opening PRs from my company Github organization is our guideline for contributing to open source in work hours. So far nobody complained about extra refs being a problem (Even when contributing to much bigger repo, such as https://github.com/DefinitelyTyped/DefinitelyTyped).

Since PRs once opened permanently pollute a repo, I will not release a fix for this until I can force push to this PR, so this PR now blocks the release.

I see you already released the patch (Good call, given we're in two very different time zones), so closing this PR.

[ljharb]

@slaweet it'd still have fixed things for me if you did the force push command i asked for, so i'm disappointed you've deleted the branch and closed the PR.

That company guideline is a bad idea in general - it's not idiomatic for the open source ecosystem - but in this case, it's a github bug where the "allow edits" setting only works when PRs are made from a fork you own. I realize most people don't care about the extra refs issue, but the "allow edits" thing is going to have a wider net.

In the future, please make PRs from your own fork; hopefully your company can change it's ill-conceived policy.