Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test] import/named should support export = assignment of object in TS #2428

Merged
merged 1 commit into from Apr 12, 2022

Conversation

ProdigySim
Copy link
Contributor

This pattern is valid typescript, but import/named can't find resolve the imports. Relevant issue: #1984

Here's a demo showing that it should work in TS

This test currently does not run, as no TS tests in named.js are currently running: waiting for #2427

Once the test is wired up, it fails with:

  1) TypeScript named [TypeScript] valid import { FooBar } from './typescript-export-assign-object':

      AssertionError [ERR_ASSERTION] [ERR_ASSERTION]: Should have no errors but had 1: [
  {
    ruleId: 'named [TypeScript]',
    severity: 1,
    message: "FooBar not found in './typescript-export-assign-object'",
    line: 1,
    column: 10,
    nodeType: 'Identifier',
    endLine: 1,
    endColumn: 16
  }
]
      + expected - actual

      -1
      +0

@ljharb ljharb merged commit a49e72a into import-js:main Apr 12, 2022
@ljharb
Copy link
Member

ljharb commented Apr 12, 2022

whoops, didn't mean to merge this.

i'm going to revert it; it'd be great if you could open a new PR re-adding it.

@ProdigySim
Copy link
Contributor Author

You got it, thanks for taking a look at these @ljharb! Reopened at #2432

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants