Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: one failing test case from for import type cases in no-restricted-paths #2574

Merged
merged 1 commit into from Oct 19, 2022

Conversation

azyzz228
Copy link
Contributor

#2450

In proposed solution for #2450, there was one test case which was failing. I pulled the changes of that developer, updated repo with latest changes, then fixed one failing test case.

Co-authored-by: Max <golergka@gmail.com>
Co-authored-by: Aziz Abdullaev <aziz.saidmuratov@duke.edu>
@ljharb
Copy link
Member

ljharb commented Oct 18, 2022

When there's an existing PR, like #2459, please don't create a new one - instead, comment a link to your branch and I can pull in the changes.

@azyzz228
Copy link
Contributor Author

will do! Thanks

@ljharb
Copy link
Member

ljharb commented Oct 18, 2022

Now that it's open though, please leave this open so I can keep them in sync.

@ljharb ljharb marked this pull request as ready for review October 19, 2022 21:48
@ljharb ljharb merged commit c3d14cb into import-js:main Oct 19, 2022
@azyzz228 azyzz228 deleted the aziz_dev branch October 21, 2022 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants