Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support eslint flat config #2873

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Support eslint flat config #2873

wants to merge 2 commits into from
+12 −0

Conversation

OlivierZal
Copy link

No description provided.

@OlivierZal OlivierZal mentioned this pull request Sep 3, 2023
Draft
@OlivierZal OlivierZal force-pushed the olivierzal/imports_rules/eslint_flat_config_support branch 2 times, most recently from d20d08a to b0da628 Compare September 4, 2023 11:18
@OlivierZal OlivierZal force-pushed the olivierzal/imports_rules/eslint_flat_config_support branch from b0da628 to 0102dc8 Compare September 4, 2023 11:41
ljharb
ljharb requested changes Oct 19, 2023
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it'd be great to have some kind of test that this actually works, perhaps with a test fixture project that uses the flat config, and we run eslint on it and assert on the output?

@ljharb ljharb marked this pull request as draft October 19, 2023 17:09
@ljharb ljharb mentioned this pull request Dec 17, 2023
Closed
@ljharb ljharb mentioned this pull request Dec 30, 2023
Open
@aladdin-add aladdin-add mentioned this pull request Jan 4, 2024
Closed
1 task
@mdjermanovic mdjermanovic mentioned this pull request Feb 6, 2024
Open
69 tasks
@nnmrts nnmrts mentioned this pull request Feb 18, 2024
Open
@ljharb ljharb mentioned this pull request May 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@OlivierZal @ljharb