Fix/newline after import #2952
Open
Fix/newline after import #2952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
reviewed
Jan 12, 2024
ljharb
reviewed
Jan 14, 2024
Comment on lines
-855
to
-856
| code: `const foo = require('foo');\n\n\n// some random comment\nconst bar = function() {};`, | ||
| options: [{ count: 2, exactCount: true, considerComments: true }], |
There was a problem hiding this comment.
can we keep this existing test case, to ensure it's not a breaking change?
There was a problem hiding this comment.
This test case is valid, so if we want to keep it, I think the test case should be included in the valid array. Is it okay to do this?
There was a problem hiding this comment.
Sure, that's fine - moving the test shows it's a bug fix.
|
Any news about this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #2905