Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add some comments and jsdocs to ExportMap #2981

Closed
wants to merge 3 commits into from

Conversation

soryy708
Copy link
Contributor

ExportMap is difficult to follow, so lets add some helpful comments.

@soryy708
Copy link
Contributor Author

I don't understand why continuous-integration/appveyor/pr failed.

Error: spawn nyc ENOENT
    at notFoundError (C:\projects\eslint-plugin-import\node_modules\cross-spawn\lib\enoent.js:11:11)
    at verifyENOENT (C:\projects\eslint-plugin-import\node_modules\cross-spawn\lib\enoent.js:46:16)
    at ChildProcess.cp.emit (C:\projects\eslint-plugin-import\node_modules\cross-spawn\lib\enoent.js:33:19)
    at Process.ChildProcess._handle.onexit (node:internal/child_process:293:12)
Emitted 'error' event on ChildProcess instance at:
    at ChildProcess.cp.emit (C:\projects\eslint-plugin-import\node_modules\cross-spawn\lib\enoent.js:36:37)
    at Process.ChildProcess._handle.onexit (node:internal/child_process:293:12) {
  errno: 'ENOENT',
  code: 'ENOENT',
  syscall: 'spawn nyc'
}
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! eslint-plugin-import@2.29.1 mocha: `cross-env BABEL_ENV=test nyc mocha "tests/src"`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the eslint-plugin-import@2.29.1 mocha script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

Did it fail to find nyc installed?

@ljharb
Copy link
Member

ljharb commented Mar 14, 2024

No need to worry about that; adding types to the util package seems to have broken appveyor.

@ljharb ljharb marked this pull request as draft March 14, 2024 05:51
@soryy708
Copy link
Contributor Author

stale.

@soryy708 soryy708 closed this Mar 21, 2024
@ljharb
Copy link
Member

ljharb commented Mar 21, 2024

That's fine, but let's reuse this PR rather than making a new one if a similar change comes up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants