separate export map from its builder #2985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
approved these changes
Mar 19, 2024
ljharb
force-pushed
the
export-map-separate-factory
branch
from
cc1b19e
to
7a28ba2
Compare
ljharb
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ExportMapis currently a very large file that is hard to follow, and therefore hard to maintain.I identified that its static methods, which are responsible for building instances of
ExportMap, can be generalized to the builder software design pattern.Lets make the separation, to make it clear that instances of
ExportMaparen't coupled to any of the globals or procedures that are currently inExportMap.js.It's also good to rename the files and classes appropriately.