Feat/verification attestation #442
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: chaosinthecrd <tom@tmlabs.co.uk>
status) Signed-off-by: chaosinthecrd <tom@tmlabs.co.uk>
Signed-off-by: chaosinthecrd <tom@tmlabs.co.uk>
Signed-off-by: chaosinthecrd <tom@tmlabs.co.uk>
…ess into improve-verify-errors Signed-off-by: chaosinthecrd <tom@tmlabs.co.uk>
Signed-off-by: chaosinthecrd <tom@tmlabs.co.uk>
Signed-off-by: chaosinthecrd <tom@tmlabs.co.uk>
✅ Deploy Preview for witness-project canceled.
|
Merged
Signed-off-by: Tom Meadows <tom@tmlabs.co.uk>
Signed-off-by: chaosinthecrd <tom@tmlabs.co.uk>
Signed-off-by: chaosinthecrd <tom@tmlabs.co.uk>
Signed-off-by: chaosinthecrd <tom@tmlabs.co.uk>
Signed-off-by: John Kjell <john@testifysec.com>
Signed-off-by: John Kjell <john@testifysec.com>
Signed-off-by: John Kjell <john@testifysec.com>
|
It looks like these changes were merged in from somewhere else... 🤔 |
|
This is my fault @jkjell. I was working on multiple branches that depended on this functionality to be there. I synced those branches with this one and these changes must have been introduced when we merged one of the other PRs. |
|
One other thing to add is that I believe we still haven't added any functionality in the CLI to allow the user to handle the attestation (e.g., push to archivista, output to a file etc.). I'll aim to sort this on Monday morning. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Updated functionality for in-toto/go-witness#55, including the changes required for compatibility with in-toto/go-witness#210.
This PR is not yet ready, as in-toto/go-witness#55 introduces a verification attestation which we currently don't expose to the user correctly (in the way of flags and options for signing and saving it).
This PR cannot be merged before #430
Acceptance Criteria Met