-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reactify custom WTForms fields #6265
base: master
Are you sure you want to change the base?
Conversation
I recommend adding some wrappers for the different object types - check the |
I guess we can skip the abstracts one for now, right? |
yeah... unless we want to move all dialogs in one go, which might actually not be such a bad idea considering the huge amount of awful complexity the wtforms-based backend of this field requires (for sending back the data when re-rendering the form) |
a46c92d
to
b7bc845
Compare
a29f289
to
71d3482
Compare
22e730e
to
a1cebf4
Compare
a1cebf4
to
2aa5840
Compare
2aa5840
to
cdf0932
Compare
This PR adds the following components:
FinalPersonLinkField
, so that thePersonLinkField
can be added to final formsSessionColorPicker
and aFinalSessionColorPicker
LocationField
and aFinalLocationField
ItemListField
, aFinalItemListField
and aFinalReferencesField
Moreover, it includes a new
dev
module with a page to test all of the custom React fields in/dev/react/fields
. Also, theChoicesSetup
was refactored using the newItemListField
.This will be important for future rectifying of timetable-related dialogs for #6220.