Improve event social share widget #6289
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GovernmentPlates
force-pushed
the
Mastodon-Sharer
branch
from
cb81000
to
a64efa9
Compare
GovernmentPlates
force-pushed
the
Mastodon-Sharer
branch
from
a64efa9
to
dadc9c2
Compare
tomasr8
reviewed
Apr 11, 2024
ThiefMaster
reviewed
Apr 11, 2024
GovernmentPlates
force-pushed
the
Mastodon-Sharer
branch
from
dadc9c2
to
9b3079f
Compare
|
Two comments:
|
If any API credentials etc were needed I'd agree, but since that's not the case I'm not so sure... is there any good usecase why someone would want to show just some social share options? In the end users can just copy the link manually to any social media site anyway
I think considering what most people think and also your smiley reaction at the end, we have some good arguments to stick with the old one :P |
GovernmentPlates
force-pushed
the
Mastodon-Sharer
branch
from
9b3079f
to
b0f6d17
Compare
GovernmentPlates
force-pushed
the
Mastodon-Sharer
branch
5 times, most recently
from
c5dfabb
to
13721c1
Compare
ThiefMaster
reviewed
May 8, 2024
GovernmentPlates
force-pushed
the
Mastodon-Sharer
branch
from
13721c1
to
a2fb104
Compare
tomasr8
reviewed
May 15, 2024
indico/web/client/js/custom_elements/ind_share_widget.module.scss
Outdated
Show resolved
Hide resolved
GovernmentPlates
force-pushed
the
Mastodon-Sharer
branch
4 times, most recently
from
9b82730
to
73aee23
Compare
ThiefMaster
force-pushed
the
Mastodon-Sharer
branch
from
73aee23
to
0dfea5c
Compare
ThiefMaster
reviewed
Jun 4, 2024
indico/modules/users/util.py
Outdated
| except requests.RequestException: | ||
| return None | ||
| try: | ||
| data = resp.json() |
There was a problem hiding this comment.
I think this may raise an error that's not handled if you get a successful response that's not valid JSON
GovernmentPlates
force-pushed
the
Mastodon-Sharer
branch
from
f9dcd69
to
25e2061
Compare
ThiefMaster
reviewed
Jun 6, 2024
GovernmentPlates
force-pushed
the
Mastodon-Sharer
branch
from
25e2061
to
2e51b2e
Compare
Show popup if none is set by the user (WIP)
This fixes an issue where using `window.open()` would trigger the pop-up blocker in FF (and other browsers except Chrome)
* Use custom URL validator in both popup and user settings page * Ensure mastodon server URL is included when exporting data * Tweak user_vars and popup * Split `<SocialButton>` component into two seperate components (reduce complexity) * Fix i18n issues in `<CalendarButtons>` component * Attempt to fix-up hardcoded margins * Add success message when the event link copied
GovernmentPlates
force-pushed
the
Mastodon-Sharer
branch
from
2e51b2e
to
b903c39
Compare
- Verify that a given Mastodon URL is valid - Display Mastodon details (server name and domain) in UI - Prevent long server names from breaking the UI - Adjust validation
GovernmentPlates
force-pushed
the
Mastodon-Sharer
branch
from
b903c39
to
519b355
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the legacy social share widget and replaces it with a more modern share widget (as well as adding in support for Mastodon).
TODO:
Preview:
