i18n: Correctly expand fields in 'format_skeleton' #6293
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally came up here: https://talk.getindico.io/t/japanese-ja-translation-group/542/18
The current behaviour of
_adjust_skeleton
produces incorrect date formatting for Japanese. This fixes the function to only perform allowed expansions.More on this: https://cldr-smoke.unicode.org/spec/main/ldml/tr35-dates.html#Matching_Skeletons
Here's the effect this has on the meeting page (
event/XXX
):The week overview page (
category/XXX/overview?period=week
) doesn't change except for displaying correctly in Japanese11月月20日月曜日
->11月20日月曜日
FWIW, more recent versions of CLDR do have a specific skeleton for
EEEEdMMMM
so we'll be able to get the full week day once babel updates.