Add exception when port is passed in host #6297
Open
+8
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThiefMaster
requested changes
Apr 15, 2024
CHANGES.rst
Outdated
| @@ -29,6 +29,7 @@ Bugfixes | |||
| purged when cloning an event (:pr:`6288`) | |||
| - Use English locale when formatting dates for room booking log entries (:pr:`6295`) | |||
| - Fix date validation in room booking failing in certain timezones | |||
| - Add a custom exception if hostname contains port number. (:pr:`6297`) | |||
There was a problem hiding this comment.
This type of change does not really need a changelog entry... it's just validation in a developer-only tool
|
@ThiefMaster we can merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raise correct error message when error is passed in host
Reference: https://talk.getindico.io/t/setup-related-error/3501