-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to make regforms private #6321
Add option to make regforms private #6321
Conversation
Wouldn't it make sense to use a token instead of allowing access by just knowing the (easy to enumerate) URL, similar like we do for private surveys? |
Not for us, as if the privacy is needed, there is already the Invitation feature. |
What I mean is that it'd just affect the link you send - it's still be the same link for everyone. So I think for your usecase it would work just as well, it'd just avoid users enabling this and not realizing that it doesn't really restrict anything. |
The endpoint ".display_regform" with token is already used for participants to access their own registrations.
|
How about In principle UUIDs are unique enough to share the same query arg - so you could also first check if it's a valid registration token and otherwise check if it's a regform token, but I think it adds unnecessary complexity, so the Logic wise you'd only check the form token if no registration token is specified. |
6c25a45
to
dccb72f
Compare
indico/migrations/versions/20240501_1431_67e92eeca34f_add_hide_registration_form.py
Outdated
Show resolved
Hide resolved
indico/modules/events/registration/controllers/management/regforms.py
Outdated
Show resolved
Hide resolved
dccb72f
to
60161ac
Compare
9911423
to
5699a15
Compare
1c080cd
to
2cc044b
Compare
@vtran99 I fixed a few issues and as far as I'm concerned it's good to be merged now. Feel free to have a last look as well. |
This also fixes a bug where the invitation token was not correctly passed on to file upload endpoints and thus uploading files would have failed in case of an invitation to register for an otherwise restricted event.
Co-authored-by: Dominic H. <dom@dominic.sk>
ce9c8d1
to
b4762d8
Compare
Request to add feature to hide registration form from the event home page.
Add a new setting in registration form to hide the form.
Once the form is hidden, it's not displayed on the event home page but is still accessible via the normal registration link.
There is no change on behaviour of the registration form:
users can register if they access via the url and the registration is still open.