Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to make regforms private #6321

Merged
merged 15 commits into from
May 28, 2024

Conversation

vtran99
Copy link
Contributor

@vtran99 vtran99 commented May 3, 2024

Request to add feature to hide registration form from the event home page.

Add a new setting in registration form to hide the form.
Once the form is hidden, it's not displayed on the event home page but is still accessible via the normal registration link.
There is no change on behaviour of the registration form:
users can register if they access via the url and the registration is still open.

image

@github-actions github-actions bot added the alembic Contains database changes label May 3, 2024
@ThiefMaster
Copy link
Member

Wouldn't it make sense to use a token instead of allowing access by just knowing the (easy to enumerate) URL, similar like we do for private surveys?

@vtran99
Copy link
Contributor Author

vtran99 commented May 3, 2024

Wouldn't it make sense to use a token instead of allowing access by just knowing the (easy to enumerate) URL, similar like we do for private surveys?

Not for us, as if the privacy is needed, there is already the Invitation feature.
Our use case:
for big events, Managers close registration to public the last day or (1 day before), but still want to allow some extra registrations requested, in which case they send the link of the hidden registration.
The link is not always sent to final users, it can be sent to the focal point of the group they want to allow late registrations.
They still do the check and approval for those late registrations, so if some unknown users use the link, they will reject...

@ThiefMaster
Copy link
Member

What I mean is that it'd just affect the link you send - it's still be the same link for everyone.

So I think for your usecase it would work just as well, it'd just avoid users enabling this and not realizing that it doesn't really restrict anything.

@vtran99
Copy link
Contributor Author

vtran99 commented May 6, 2024

The endpoint ".display_regform" with token is already used for participants to access their own registrations.
How would you like to proceed to add token to the hidden regform url:

  • use a different token keyword, eg: "token_regform" ?
  • use a different endpoint and class for that purpose ? (in this case, any preference for the naming of endpoint/class ?)

@ThiefMaster
Copy link
Member

How about form_token?

In principle UUIDs are unique enough to share the same query arg - so you could also first check if it's a valid registration token and otherwise check if it's a regform token, but I think it adds unnecessary complexity, so the form_token is probably better.

Logic wise you'd only check the form token if no registration token is specified.

@vtran99 vtran99 force-pushed the Add_hide_registration_form branch from 6c25a45 to dccb72f Compare May 6, 2024 10:29
@vtran99
Copy link
Contributor Author

vtran99 commented May 6, 2024

Done: add 'form_token' to hidden registration form's url.
image

@ThiefMaster
Copy link
Member

"To register, use link" isn't correct English. My suggestion would be to show it nicely as a box in the registration management dashboard, similar to what we do for surveys. The description field when editing it isn't a great place for this anyway.

image

@vtran99 vtran99 force-pushed the Add_hide_registration_form branch from dccb72f to 60161ac Compare May 6, 2024 15:55
@vtran99
Copy link
Contributor Author

vtran99 commented May 6, 2024

Code updated following review.
image

@vtran99 vtran99 force-pushed the Add_hide_registration_form branch from 9911423 to 5699a15 Compare May 8, 2024 08:56
@ThiefMaster ThiefMaster changed the title Add hide registration form Add option to make regforms private May 27, 2024
@ThiefMaster ThiefMaster force-pushed the Add_hide_registration_form branch 2 times, most recently from 1c080cd to 2cc044b Compare May 27, 2024 16:12
@ThiefMaster
Copy link
Member

@vtran99 I fixed a few issues and as far as I'm concerned it's good to be merged now. Feel free to have a last look as well.

@ThiefMaster ThiefMaster added this to the v3.3 milestone May 27, 2024
ThiefMaster and others added 8 commits May 28, 2024 16:05
This also fixes a bug where the invitation token was not correctly
passed on to file upload endpoints and thus uploading files would have
failed in case of an invitation to register for an otherwise restricted
event.
Co-authored-by: Dominic H. <dom@dominic.sk>
@ThiefMaster ThiefMaster enabled auto-merge (squash) May 28, 2024 14:06
@ThiefMaster ThiefMaster merged commit f755710 into indico:master May 28, 2024
9 checks passed
@ThiefMaster ThiefMaster deleted the Add_hide_registration_form branch May 28, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alembic Contains database changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants