Use abstract default roles in contrib persons #6342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As discussed during our last meeting, it would be better to only change the logic when editing a contribution linked to an abstract. That way you avoid changing the behavior for events that use the "conference" event type but aren't real conferences, while having consistent behavior between CfA and contribution management for actual conferences. |
duartegalvao
force-pushed
the
contrib-plf-no-default-roles
branch
from
3380c45
to
cd91b0e
Compare
duartegalvao
changed the title
ThiefMaster
reviewed
May 30, 2024
duartegalvao
force-pushed
the
contrib-plf-no-default-roles
branch
from
cd91b0e
to
6cd9af3
Compare
duartegalvao
force-pushed
the
contrib-plf-no-default-roles
branch
from
6cd9af3
to
8013829
Compare
ThiefMaster
force-pushed
the
contrib-plf-no-default-roles
branch
from
8013829
to
805c20b
Compare
ThiefMaster
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when adding people to contributions, they are attributed the "speaker" and "submitter" roles, but no author roles. Most people then save without realizing that they need to set the proper roles. WIth no default roles, the field validation will fail, making it obvious to the users that they need to set them.
This will also make the behavior of the field more similar to CfA.