[React] Use updater function for key-value data setter in useForm hook #1859
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal for changing the ergonomics of the key-value variant for the
setData
hook in React.Current behaviour
Using this simple form as an example:
It is expected that sequential calls to
setData
will update the form data accordingly. However, subsequent calls overwrite the changes made by the previous calls.Desired behaviour
Sequential
setData
calls use an updater function to batch the changes from multiple calls.This can be achieved using updater functions for the set functions in React. From React documentation:
It is worth noting that this only affects the key-value variant of the
setData
function, and if anyone is impacted by this change, they can switch to the object variant of thesetData
function.