Do not remove attributes from class methods when visibility is mutated (

#1896) Previously, attributes were removed when e.g. `public` was mutated to `protected`. Now, attributes are retained.
infection · Nov 8, 2023 · 673ce76 · 673ce76
1 parent e5bf714
commit 673ce76
Show file tree

Hide file tree

Showing 4 changed files with 74 additions and 0 deletions.
diff --git a/src/Mutator/FunctionSignature/ProtectedVisibility.php b/src/Mutator/FunctionSignature/ProtectedVisibility.php
@@ -82,6 +82,7 @@ public function mutate(Node $node): iterable
                 'params' => $node->getParams(),
                 'returnType' => $node->getReturnType(),
                 'stmts' => $node->getStmts(),
+                'attrGroups' => $node->getAttrGroups(),
             ],
             $node->getAttributes()
         );

diff --git a/src/Mutator/FunctionSignature/PublicVisibility.php b/src/Mutator/FunctionSignature/PublicVisibility.php
@@ -81,6 +81,7 @@ public function mutate(Node $node): iterable
                 'params' => $node->getParams(),
                 'returnType' => $node->getReturnType(),
                 'stmts' => $node->getStmts(),
+                'attrGroups' => $node->getAttrGroups(),
             ],
             $node->getAttributes()
         );

diff --git a/tests/phpunit/Mutator/FunctionSignature/ProtectedVisibilityTest.php b/tests/phpunit/Mutator/FunctionSignature/ProtectedVisibilityTest.php
@@ -227,5 +227,41 @@ private function anything()
 }
 PHP
         ];
+
+        yield 'It does not remove attributes' => [
+            <<<'PHP'
+<?php
+
+namespace PublicVisibilityOneClass;
+
+class Test
+{
+    #[SomeAttribute1]
+    #[SomeAttribute2]
+    protected function &foo(int $param, $test = 1) : bool
+    {
+        echo 1;
+        return false;
+    }
+}
+PHP,
+            <<<'PHP'
+<?php
+
+namespace PublicVisibilityOneClass;
+
+class Test
+{
+    #[SomeAttribute1]
+    #[SomeAttribute2]
+    private function &foo(int $param, $test = 1) : bool
+    {
+        echo 1;
+        return false;
+    }
+}
+PHP
+            ,
+        ];
     }
 }
diff --git a/tests/phpunit/Mutator/FunctionSignature/PublicVisibilityTest.php b/tests/phpunit/Mutator/FunctionSignature/PublicVisibilityTest.php
@@ -343,5 +343,41 @@ protected function foo() : bool
             }];
             PHP,
         ];
+
+        yield 'It does not remove attributes' => [
+            <<<'PHP'
+<?php
+
+namespace PublicVisibilityOneClass;
+
+class Test
+{
+    #[SomeAttribute1]
+    #[SomeAttribute2]
+    public function &foo(int $param, $test = 1) : bool
+    {
+        echo 1;
+        return false;
+    }
+}
+PHP,
+            <<<'PHP'
+<?php
+
+namespace PublicVisibilityOneClass;
+
+class Test
+{
+    #[SomeAttribute1]
+    #[SomeAttribute2]
+    protected function &foo(int $param, $test = 1) : bool
+    {
+        echo 1;
+        return false;
+    }
+}
+PHP
+            ,
+        ];
     }
 }