Skip to content

Commit

Permalink
Enable Rector's AddCoversClassAttributeRector rule (#1962)
Browse files Browse the repository at this point in the history
* Upgrade Rector and fix new issues

* Enable Rector's `AddCoversClassAttributeRector` rule

- https://github.com/rectorphp/rector-phpunit/blob/main/docs/rector_rules_overview.md#addcoversclassattributerector
- see my explanation why it's needed rectorphp/rector-phpunit#319 (comment)
  • Loading branch information
maks-rafalko committed May 14, 2024
1 parent df56e28 commit 97818a8
Show file tree
Hide file tree
Showing 5 changed files with 13 additions and 17 deletions.
15 changes: 9 additions & 6 deletions composer.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions rector.php
Original file line number Diff line number Diff line change
Expand Up @@ -36,13 +36,17 @@
use Rector\Config\RectorConfig;
use Rector\Php80\Rector\FunctionLike\MixedTypeRector;
use Rector\Php81\Rector\Property\ReadOnlyPropertyRector;
use Rector\PHPUnit\CodeQuality\Rector\Class_\AddCoversClassAttributeRector;

return RectorConfig::configure()
->withPaths([
__DIR__ . '/src',
__DIR__ . '/tests/phpunit',
])
->withPhpSets(php81: true)
->withRules([
AddCoversClassAttributeRector::class,
])
->withSkip([
MixedTypeRector::class => [
// see https://github.com/rectorphp/rector/issues/8633
Expand Down
2 changes: 0 additions & 2 deletions src/TestFramework/Coverage/BufferedSourceFileFilter.php
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@

use function array_key_exists;
use Infection\FileSystem\FileFilter;
use Infection\FileSystem\SourceFileFilter;
use function Pipeline\take;
use Symfony\Component\Finder\SplFileInfo;
use Webmozart\Assert\Assert;
Expand All @@ -64,7 +63,6 @@ class BufferedSourceFileFilter implements FileFilter
private array $sourceFiles = [];

/**
* @param SourceFileFilter|FileFilter $filter
* @param iterable<SplFileInfo> $sourceFiles
*/
public function __construct(
Expand Down
5 changes: 0 additions & 5 deletions src/TestFramework/Coverage/CoveredTraceProvider.php
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@

use Infection\FileSystem\FileFilter;
use Infection\TestFramework\Coverage\JUnit\JUnitTestExecutionInfoAdder;
use Infection\TestFramework\Coverage\XmlReport\PhpUnitXmlCoverageTraceProvider;

/**
* Filters traces and augments them with timing data from JUnit report.
Expand All @@ -46,10 +45,6 @@
*/
final class CoveredTraceProvider implements TraceProvider
{
/**
* @param PhpUnitXmlCoverageTraceProvider|TraceProvider $primaryTraceProvider
* @param BufferedSourceFileFilter|FileFilter $bufferedFilter
*/
public function __construct(private readonly TraceProvider $primaryTraceProvider, private readonly JUnitTestExecutionInfoAdder $testFileDataAdder, private readonly FileFilter $bufferedFilter)
{
}
Expand Down
4 changes: 0 additions & 4 deletions src/TestFramework/Coverage/UnionTraceProvider.php
Original file line number Diff line number Diff line change
Expand Up @@ -43,10 +43,6 @@
*/
final class UnionTraceProvider implements TraceProvider
{
/**
* @param CoveredTraceProvider|TraceProvider $coveredTraceProvider
* @param UncoveredTraceProvider|TraceProvider $uncoveredTraceProvider
*/
public function __construct(private readonly TraceProvider $coveredTraceProvider, private readonly TraceProvider $uncoveredTraceProvider, private readonly bool $onlyCovered)
{
}
Expand Down

0 comments on commit 97818a8

Please sign in to comment.