Ignore mutations by regex for uncovered mutants (#1585)

Fixes #1561
infection · Oct 2, 2021 · f7a1af2 · f7a1af2
1 parent c3e23df
commit f7a1af2
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 12 deletions.
diff --git a/src/Process/Runner/MutationTestingRunner.php b/src/Process/Runner/MutationTestingRunner.php
@@ -104,18 +104,6 @@ public function run(iterable $mutations, string $testFrameworkExtraOptions): voi
             ->cast(function (Mutation $mutation): Mutant {
                 return $this->mutantFactory->create($mutation);
             })
-            ->filter(function (Mutant $mutant) {
-                // It's a proxy call to Mutation, can be done one stage up
-                if ($mutant->isCoveredByTest()) {
-                    return true;
-                }
-
-                $this->eventDispatcher->dispatch(new MutantProcessWasFinished(
-                    MutantExecutionResult::createFromNonCoveredMutant($mutant)
-                ));
-
-                return false;
-            })
             ->filter(function (Mutant $mutant) {
                 $mutatorName = $mutant->getMutation()->getMutatorName();
 
@@ -131,6 +119,18 @@ public function run(iterable $mutations, string $testFrameworkExtraOptions): voi
 
                 return true;
             })
+            ->filter(function (Mutant $mutant) {
+                // It's a proxy call to Mutation, can be done one stage up
+                if ($mutant->isCoveredByTest()) {
+                    return true;
+                }
+
+                $this->eventDispatcher->dispatch(new MutantProcessWasFinished(
+                    MutantExecutionResult::createFromNonCoveredMutant($mutant)
+                ));
+
+                return false;
+            })
             ->filter(function (Mutant $mutant) {
                 // TODO refactor this comparison into a dedicated comparer to make it possible to swap strategies
                 if ($mutant->getMutation()->getNominalTestExecutionTime() < $this->timeout) {

diff --git a/tests/e2e/Exclude_Mutations_By_Regex/src/SourceClass.php b/tests/e2e/Exclude_Mutations_By_Regex/src/SourceClass.php
@@ -10,7 +10,9 @@ public function hello(): string
     {
         Assert::numeric('1');
 
+        // @codeCoverageIgnoreStart
         $this->getString();
+        // @codeCoverageIgnoreEnd
 
         return 'hello';
     }