Remove large group (#1115) #1117
Conversation
|
in
So this PR is quite dangerous, this very large test will be executed with other We should ask @sanmai why it was added. Probably we don't need it? |
|
When do we ever execute it then? I could not find any occurrence anywhere |
| public function test_it_runs_on_itself(): void | ||
| { | ||
| if (ini_get('memory_limit') === '-1') { | ||
| $this->markTestSkipped(implode("\n", [ | ||
| 'Refusing to run Infection on itself with no memory limit set: it is dangerous.', | ||
| 'To run this test with a memory limit set please use:', | ||
| 'php -dmemory_limit=128M vendor/bin/phpunit --group=large', | ||
| 'php -dmemory_limit=128M vendor/bin/phpunit --group=e2e', |
There was a problem hiding this comment.
When this was written, the entire test suite wasn't marked as e2e.
In any case this isn't the test you want to run every time.
|
The build is failing with:
Issue #1119 |
| * | ||
| * php -dmemory_limit=128M vendor/bin/phpunit --group=large | ||
| * | ||
| * @large |
There was a problem hiding this comment.
I'd rather keep this designation. And explanation to its existence. It is really slow. I think even slower these days.
| <exclude> | ||
| <group>large</group> | ||
| </exclude> | ||
| </groups> |
There was a problem hiding this comment.
And so is best to ignore this group too, IMO.
|
About removing, this is a fine test, for example, to run when you want to find dead code. As it is only few lines of code, I propose to keep it. |
theofidry
changed the title
|
Closing in favour of #1120 |
As far as I can see this group is not actually used and this test is run as part of
e2e. @maks-rafalko can you confirm?