Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update E2ETest #1120

Closed
wants to merge 15 commits into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 6 additions & 5 deletions tests/phpunit/Console/E2ETest.php
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ final class E2ETest extends TestCase
protected function setUp(): void
{
if (PHP_SAPI === 'phpdbg') {
$this->markTestSkipped('Running this test on PHPDBG causes failures on Travis, see https://github.com/infection/infection/pull/622.');
$this->markTestSkipped('Running this test with PHPDBG causes failures due to segmentation faults, which are due to bugs beyond our control.');
}

if (getenv('DEPS') === 'LOW') {
Expand Down Expand Up @@ -126,26 +126,27 @@ protected function tearDown(): void
}

/**
* Longest test: runs under about 160-200 sec
* Longest test: takes in range of several minutes to run.
*
* To be run with:
*
* php -dmemory_limit=128M vendor/bin/phpunit --group=large
* php -dmemory_limit=512M vendor/bin/phpunit --group=large
*
* @large
* @coversNothing
*/
public function test_it_runs_on_itself(): void
{
if (ini_get('memory_limit') === '-1') {
$this->markTestSkipped(implode("\n", [
'Refusing to run Infection on itself with no memory limit set: it is dangerous.',
'To run this test with a memory limit set please use:',
'php -dmemory_limit=128M vendor/bin/phpunit --group=large',
'php -dmemory_limit=512M vendor/bin/phpunit --group=large',
]));
}

$output = $this->runInfection(self::EXPECT_SUCCESS, [
'--test-framework-options=--exclude-group=' . self::EXCLUDED_GROUP,
sprintf('--test-framework-options=--exclude-group=%s', self::EXCLUDED_GROUP),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing, but probably quotes affects somehow the build. It's now written in a different way

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It didn't help  :see_no_evil:

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not many cases left to revert :) next is --no-progress?

Copy link
Member Author

@sanmai sanmai Mar 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's more like something isn't added here.

sanmai marked this conversation as resolved.
Show resolved Hide resolved
]);

$this->assertMatchesRegularExpression('/\d+ mutations were generated/', $output);
Expand Down