Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve CPU core count detection: integrate FidryCpuCoreCounter #1767

Merged
merged 5 commits into from Dec 11, 2022
Merged

Improve CPU core count detection: integrate FidryCpuCoreCounter #1767

merged 5 commits into from Dec 11, 2022

Conversation

theofidry
Copy link
Member

@theofidry theofidry commented Dec 4, 2022 •
edited

See theofidry/cpu-core-counter#11 for the motivations.

The code should be sensibly the same, the notable differences are:

  • fixed the deprecated usage of hw.ncpu
  • add more ways to detect the CPU core counts
  • better handling of failures

@theofidry theofidry marked this pull request as ready for review December 4, 2022 19:57
@theofidry theofidry mentioned this pull request Dec 4, 2022
Closed
7 tasks
maks-rafalko
maks-rafalko approved these changes Dec 4, 2022
View reviewed changes
Copy link
Member

@maks-rafalko maks-rafalko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with it, makes sense to reuse the code rather than copy

@theofidry theofidry enabled auto-merge (squash) December 11, 2022 00:32
@theofidry theofidry changed the title Integrate FidryCpuCoreCounter Improve CPU core count detection: integrate FidryCpuCoreCounter Dec 11, 2022
@theofidry theofidry enabled auto-merge (squash) December 11, 2022 00:33
@theofidry theofidry merged commit b784620 into infection:master Dec 11, 2022
@theofidry theofidry deleted the feature/cpu-core-counter branch December 11, 2022 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanmai sanmai sanmai approved these changes

@maks-rafalko maks-rafalko maks-rafalko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@theofidry @sanmai @maks-rafalko