Add GH Action to requrie tests in Pull Requests #1848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we had a GitHub App - Tests Checker - https://github.com/infection/tests-checker to automatically request changes in opened PR if source code is changed without changing/adding tests.
However, GitHub App requires deploying application to 3rd-party server, which means more maintenance and work from my side.
I've rewrote this app as a GitHub action - https://github.com/infection/tests-checker-action - and will deprecate GitHub App.
So basically nothing new here, same functionality but with Action instead of App.
I will open a test PR after merging to check if it works and if we have enough permissions from github toketn