Add PHP-Parser 5 support #1909

sidz · 2024-01-08T21:06:37Z

This PR:

Adds PHP-Parser 5 support. (Upgrade guide)
Fixes Clean project ApiPlatform + PhpUnit 11 + PHP 8.3.x -> nikic/php-parser minimum version bump needed #1918

…t\TryCatch constructor

…e ca not be null

theofidry

👍 for the PR. I think however there is a few unrelated changes that could be extracted for clarity.

I am also a bit confused, is the PHP-Parser API changes working on 4.x? In which case we could migrate to it before allowing PHP-Parser 5.x

src/Mutator/Operator/Finally_.php

src/Mutator/Removal/MatchArmRemoval.php

src/Mutation/Mutation.php

sidz · 2024-01-14T08:53:11Z

I am also a bit confused, is the PHP-Parser API changes working on 4.x?

The main issue in tests: we will have to support 2 sets of tests in some cases. Also it looks like we will have to override Pretty Printer

ttomdewit · 2024-02-09T07:56:45Z

When I try to install with this branch it also signals that it needs to update sebastian/diff to ^6.0.0.

  Problem 2
    - Root composer.json requires infection/infection dev-add-php-parser-5-support@dev -> satisfiable by infection/infection[dev-add-php-parser-5-support].
    - infection/infection dev-add-php-parser-5-support requires sebastian/diff ^3.0.2 || ^4.0 || ^5.0 -> satisfiable by sebastian/diff[3.0.2, 3.0.3, 3.0.4, 4.0.0, ..., 4.0.5, 5.0.0, ..., 5.1.0].
    - You can only install one version of a package, so only one of these can be installed: sebastian/diff[3.0.2, 3.0.3, 3.0.4, 4.0.0, ..., 4.0.5, 5.0.0, ..., 5.1.0, 6.0.0].
    - phpunit/phpunit[11.0.0, ..., 11.0.2] require sebastian/diff ^6.0 -> satisfiable by sebastian/diff[6.0.0].
    - Root composer.json requires phpunit/phpunit ^11.0.0 -> satisfiable by phpunit/phpunit[11.0.0, 11.0.1, 11.0.2].

sidz · 2024-02-09T08:03:21Z

sebastian/diff released 7 days ago with phpunit 11. As an option you could downgrade phpunit.

also we have openned PR to add support for sebastian/diff: ^6.0 #1913

ttomdewit · 2024-02-09T08:12:49Z

sebastian/diff released 7 days ago with phpunit 11. As an option you could downgrade phpunit.

also we have openned PR to add support for sebastian/diff: ^6.0 #1913

Sorry I completely missed that one! I was aiming to get PHPUnit 11 running in my project, hence me trying this branch. Best of luck wrapping up, looking forward to upgrading!

…s merged See infection#1913 (comment)

See #1913 (comment)

darthf1 · 2024-03-05T14:26:01Z

Is this ready now that #1913 is merged? :)

sidz · 2024-03-13T19:56:36Z

The main issue in tests: we will have to support 2 sets of tests in some cases. Also it looks like we will have to override Pretty Printer

What about dropping support for PHP-Parser 4 in release 0.30? @infection/core

maks-rafalko · 2024-03-13T23:31:57Z

I have to say that I'm not understanding the current issues with tests and pretty printer yet, but I'm completely ok with dropping support for php-parser v4.

In the worst case if some project is stuck with php-parser v4 and want new Infection - infection.phar can be used.

UPD: I think now I understand why we would need to support 2 versions in tests, because pretty printer output has changed. Yeah, let's not do it.

# Conflicts: # composer.json # composer.lock # src/Mutator/IgnoreMutator.php # tests/phpunit/Mutant/MutantCodeFactoryTest.php # tests/phpunit/Mutator/Arithmetic/MultiplicationTest.php # tests/phpunit/Mutator/Boolean/Yield_Test.php # tests/phpunit/Mutator/FunctionSignature/ProtectedVisibilityTest.php # tests/phpunit/Mutator/FunctionSignature/PublicVisibilityTest.php # tests/phpunit/Mutator/Loop/Foreach_Test.php # tests/phpunit/Mutator/Regex/PregMatchMatchesTest.php # tests/phpunit/Mutator/ReturnValue/ArrayOneItemTest.php # tests/phpunit/Mutator/ReturnValue/FunctionCallTest.php # tests/phpunit/Mutator/ReturnValue/NewObjectTest.php # tests/phpunit/Mutator/ReturnValue/YieldValueTest.php # tests/phpunit/Mutator/Util/AbstractValueToNullReturnValueTest.php # tests/phpunit/PhpParser/FileParserTest.php # tests/phpunit/PhpParser/Visitor/MutatorVisitorTest.php # tests/phpunit/PhpParser/Visitor/ParentConnectorVisitorTest.php

# Conflicts: # tests/phpunit/PhpParser/Visitor/MutatorVisitorTest.php

… merged" This reverts commit 873cd33.

maks-rafalko · 2024-03-23T17:39:14Z

@sidz please review 😃

sidz

LGTM @maks-rafalko

maks-rafalko · 2024-03-23T18:40:20Z

Thanks for your hard work @sidz, let's merge and release

maks-rafalko · 2024-03-23T18:49:30Z

Released https://github.com/infection/infection/releases/tag/0.28.0

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [infection/infection](https://togithub.com/infection/infection) | `^0.27.11` -> `^0.28.0` | [![age](https://developer.mend.io/api/mc/badges/age/packagist/infection%2finfection/0.28.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/packagist/infection%2finfection/0.28.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/packagist/infection%2finfection/0.27.11/0.28.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/packagist/infection%2finfection/0.27.11/0.28.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>infection/infection (infection/infection)</summary> ### [`v0.28.0`](https://togithub.com/infection/infection/blob/HEAD/CHANGELOG.md#0280-2024-03-23) [Compare Source](https://togithub.com/infection/infection/compare/0.27.11...0.28.0) [Full Changelog](https://togithub.com/infection/infection/compare/0.27.11...0.28.0) **Added:** - Add PHP-Parser 5 support by [@sidz](https://togithub.com/sidz) in [infection/infection#1909 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/Lendable/json-serializer).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

sidz added 11 commits January 9, 2024 00:05

Add PHP-Parser 5 support

6bb008c

fix PHP-Parser 5 breaking changes and deprecations

b89d64c

Change Throw mutator due to internal changes in PHP-Parser

b59cbf6

Change PregQuite mutator due to internal changes in PHP-Parser and AST

13f7282

Change Finally_ mutator due to internal changes in PhpParser\Node\Stm…

95054f6

…t\TryCatch constructor

Fix failed MutantCodeFactoryTest due to renamed nodes

b4211af

Fix failed MatchArmRemoval due to changes in PHP-Parser

04cbfab

apply cs fixer

3e11ece

fix invalid AbstractValueToNullReturnValue test case. Identifier->nam…

83b65d6

…e ca not be null

revert Configuration changes

3d6b007

Fix integration tests due to AST changes

297306a

theofidry reviewed Jan 11, 2024

View reviewed changes

sidz force-pushed the add-php-parser-5-support branch 3 times, most recently from db3e7ef to d8843ed Compare January 14, 2024 11:00

Add BackwardCompatible pretty printer

4cc1b2f

sidz force-pushed the add-php-parser-5-support branch from d8843ed to 4cc1b2f Compare January 14, 2024 11:20

Fix tests

32a462a

maks-rafalko mentioned this pull request Feb 11, 2024

feat: add support for sebastian/diff v6 #1913

Merged

3 tasks

maks-rafalko added a commit to simPod/infection that referenced this pull request Feb 19, 2024

Conflict with nikic/php-parser in e2e tests unless infection#1909 i…

08691b6

…s merged See infection#1913 (comment)

maks-rafalko added a commit that referenced this pull request Feb 20, 2024

Conflict with nikic/php-parser in e2e tests unless #1909 is merged

873cd33

See #1913 (comment)

ddziaduch mentioned this pull request Feb 27, 2024

Support for typed const - PHP 8.3 qossmic/deptrac#1371

Open

maks-rafalko mentioned this pull request Mar 13, 2024

nikic/php-parser 5 support #1917

Closed

maks-rafalko mentioned this pull request Mar 17, 2024

Clean project ApiPlatform + PhpUnit 11 + PHP 8.3.x -> nikic/php-parser minimum version bump needed #1918

Closed

maks-rafalko added 4 commits March 23, 2024 13:13

Fix issues after merging master into current branch

7870d4f

Fix tests, add missed DataProvider and fixed indentation in heredocs

978fec3

Removed previously added BackwardCompatibleStandard.php

ce51c6d

maks-rafalko force-pushed the add-php-parser-5-support branch from cf098c4 to ce51c6d Compare March 23, 2024 12:48

maks-rafalko added 7 commits March 23, 2024 14:03

Fix more tests

0f05af4

Remove nikic/php-parser:4 compatibility tests

155ccd0

Fix other tests

7a96143

Merge branch 'master' into add-php-parser-5-support

5cf4af4

# Conflicts: # tests/phpunit/PhpParser/Visitor/MutatorVisitorTest.php

Fix issues after merging master

ae34407

Revert "Conflict with nikic/php-parser in e2e tests unless #1909 is…

00cd608

… merged" This reverts commit 873cd33.

Remove usage if old classes, fir phpstan/psalm errors

5383a88

maks-rafalko marked this pull request as ready for review March 23, 2024 17:36

maks-rafalko approved these changes Mar 23, 2024

View reviewed changes

sidz commented Mar 23, 2024

View reviewed changes

maks-rafalko merged commit 7375c55 into master Mar 23, 2024
55 checks passed

maks-rafalko deleted the add-php-parser-5-support branch March 23, 2024 18:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add PHP-Parser 5 support #1909

Add PHP-Parser 5 support #1909

sidz commented Jan 8, 2024 •

edited by maks-rafalko

theofidry left a comment

sidz commented Jan 14, 2024 •

edited

ttomdewit commented Feb 9, 2024

sidz commented Feb 9, 2024

ttomdewit commented Feb 9, 2024

darthf1 commented Mar 5, 2024

sidz commented Mar 13, 2024

maks-rafalko commented Mar 13, 2024 •

edited

maks-rafalko commented Mar 23, 2024

sidz left a comment

maks-rafalko commented Mar 23, 2024

maks-rafalko commented Mar 23, 2024

Add PHP-Parser 5 support #1909

Add PHP-Parser 5 support #1909

Conversation

sidz commented Jan 8, 2024 • edited by maks-rafalko

theofidry left a comment

Choose a reason for hiding this comment

sidz commented Jan 14, 2024 • edited

ttomdewit commented Feb 9, 2024

sidz commented Feb 9, 2024

ttomdewit commented Feb 9, 2024

darthf1 commented Mar 5, 2024

sidz commented Mar 13, 2024

maks-rafalko commented Mar 13, 2024 • edited

maks-rafalko commented Mar 23, 2024

sidz left a comment

Choose a reason for hiding this comment

maks-rafalko commented Mar 23, 2024

maks-rafalko commented Mar 23, 2024

sidz commented Jan 8, 2024 •

edited by maks-rafalko

sidz commented Jan 14, 2024 •

edited

maks-rafalko commented Mar 13, 2024 •

edited