Attempt to improve test time adding #1966
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanmai
commented
May 18, 2024
| @@ -103,7 +103,7 @@ private function createCompleteTestLocation(TestLocation $test): TestLocation | |||
| return new TestLocation( | |||
| $test->getMethod(), | |||
| $testFileData->path, | |||
| $testFileData->time, | |||
| $test->getExecutionTime() ?? $testFileData->time, | |||
There was a problem hiding this comment.
There are per-test timings in the JUnit report I had lying around, so in theory it should be possible to get a more accurate numbers.
There was a problem hiding this comment.
could you please explain the idea of this PR? Sorry, without debugging I think I don't get it
There was a problem hiding this comment.
The idea: #1965 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
It didn't work, but I figured I'll leave some breadcrumbs for the future explorer.