Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PHP 7.4 to Travis CI #817

Merged
merged 10 commits into from
Feb 13, 2020
Merged

Conversation

sanmai
Copy link
Member

@sanmai sanmai commented Nov 5, 2019

  • Add a testing stage for PHP 7.4 + xdebug
  • Require build passing for 7.4

This PR:

@sanmai sanmai added this to the 0.15.0 milestone Nov 15, 2019
@maks-rafalko maks-rafalko modified the milestones: 0.15.0, 0.16.0 Nov 29, 2019
@sanmai
Copy link
Member Author

sanmai commented Dec 9, 2019

There's a hiccup with Codeception something, @maks-rafalko can you have a look?

@maks-rafalko
Copy link
Member

requires ext-zip * -> the requested PHP extension zip is missing from your system.

strange.. Ok, I will have a look but in the evening. Seem like ext-zip is not installed for PHP 7.4 ....

@sanmai
Copy link
Member Author

sanmai commented Dec 9, 2019

It seems like there's a reason to it. Shall we skip this test under PHP 7.4 for time being?

@maks-rafalko
Copy link
Member

Many people from major repositories are experiencing the very same issue, as well as issues with other extensions:

So yeah, probably we just need to skip it for now and move forward.

@maks-rafalko
Copy link
Member

maks-rafalko commented Dec 10, 2019

Now Unit Tests work without errors for PHP 7.4 with XDebug.

There is an issue with Box: @theofidry you might be interested in this

The configuration file failed validation: include(): _HumbugBox3ab8cff0fda0\Opis\Closure\ClosureStream::stream_set_option is not implemented!

@theofidry
Copy link
Member

Box is not compatible with 7.4 yet: humbug/php-scoper#357

@sanmai sanmai mentioned this pull request Dec 21, 2019
- Add a testing stage for PHP 7.4 + xdebug + pcov
- Require build passing for 7.4
@sanmai
Copy link
Member Author

sanmai commented Feb 12, 2020

leanphp/phpspec-code-coverage isn't formally compatible with PhpSpec 6 which is required for PHP 7.4. What do we do?

TBH this package looks pretty much abandoned. Not a single update since 2018. Yet there's hope.

@theofidry
Copy link
Member

@sanmai hopefully we'll have an alternative to the XML coverage report as a tracer this year, at the very least for PhpSpec, so this package will no longer be necessary!

@maks-rafalko
Copy link
Member

Also, I'm working on extracting PHPSpec to a separate package, so infection/infection won't have this failing e2e test here anymore. Let's wait when it's done (and keep an eye on leanphp/phpspec-code-coverage#40)

@sanmai sanmai changed the title Making builds on PHP 7.4 pass Add PHP 7.4 to Travis CI Feb 13, 2020
@sanmai
Copy link
Member Author

sanmai commented Feb 13, 2020

Since there's work ongoing with PHPSpec, may I propose we merge this subset of changes?

Builds are failing due to unrelated issues. This PR changes nothing in terms of actual functionality, so it shouldn't introduce any new faults.

Copy link
Member

@maks-rafalko maks-rafalko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm 👌 with merging, but seems like the latest commit introduces a new issue:

https://travis-ci.org/infection/infection/jobs/649865760#L376-L380

@sanmai
Copy link
Member Author

sanmai commented Feb 13, 2020

It isn't getting better. Can we fix this in another PR, what do you think?
https://travis-ci.org/infection/infection/jobs/649890785#L378-L387

@sanmai
Copy link
Member Author

sanmai commented Feb 13, 2020

Alright fingers crossed it should be fixed.

@maks-rafalko maks-rafalko merged commit a1279ec into infection:master Feb 13, 2020
@maks-rafalko
Copy link
Member

thank you @sanmai

@sanmai
Copy link
Member Author

sanmai commented Feb 13, 2020

Thank you @maks-rafalko

@sanmai sanmai deleted the pr/201910/php74 branch February 14, 2020 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants