-
-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PHP 7.4 to Travis CI #817
Conversation
There's a hiccup with Codeception something, @maks-rafalko can you have a look? |
strange.. Ok, I will have a look but in the evening. Seem like |
It seems like there's a reason to it. Shall we skip this test under PHP 7.4 for time being? |
Many people from major repositories are experiencing the very same issue, as well as issues with other extensions:
So yeah, probably we just need to skip it for now and move forward. |
Now Unit Tests work without errors for PHP 7.4 with XDebug. There is an issue with Box: @theofidry you might be interested in this
|
Box is not compatible with 7.4 yet: humbug/php-scoper#357 |
- Add a testing stage for PHP 7.4 + xdebug + pcov - Require build passing for 7.4
ef2bcd2
to
ac1c14d
Compare
leanphp/phpspec-code-coverage isn't formally compatible with PhpSpec 6 which is required for PHP 7.4. What do we do? TBH this package looks pretty much abandoned. Not a single update since 2018. Yet there's hope. |
@sanmai hopefully we'll have an alternative to the XML coverage report as a tracer this year, at the very least for PhpSpec, so this package will no longer be necessary! |
Also, I'm working on extracting PHPSpec to a separate package, so |
Since there's work ongoing with PHPSpec, may I propose we merge this subset of changes? Builds are failing due to unrelated issues. This PR changes nothing in terms of actual functionality, so it shouldn't introduce any new faults. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm 👌 with merging, but seems like the latest commit introduces a new issue:
https://travis-ci.org/infection/infection/jobs/649865760#L376-L380
It isn't getting better. Can we fix this in another PR, what do you think? |
Alright fingers crossed it should be fixed. |
thank you @sanmai |
Thank you @maks-rafalko |
This PR: