ISPN-13981: Restore the Enabling JMX remote ports module on the 13.0.x branch #10201
Conversation
dfitzmau
added
the
Documentation
dfitzmau
force-pushed
the
ISPN-13981
branch
2 times, most recently
from
6e70e78
to
3edd09b
Compare
There was a problem hiding this comment.
@dfitzmau The file is missing conditionals and introduces several blank lines. Please copy the file from main
|
Hello @tristantarrant . Would you be OK to review this PR for the restored file? |
| ifdef::remote_caches[] | ||
| [NOTE] | ||
| ==== | ||
| {brandname} Server does not expose JMX remotely by using the single port endpoint. If you want to remotely access the {brandname} Server through JMX, you must enable a remote port. |
There was a problem hiding this comment.
Each sentence should start on its own line
| {brandname} Server does not expose JMX remotely by using the single port endpoint. If you want to remotely access the {brandname} Server through JMX, you must enable a remote port. | |
| {brandname} Server does not expose JMX remotely by using the single port endpoint. | |
| If you want to remotely access the {brandname} Server through JMX, you must enable a remote port. |
There was a problem hiding this comment.
Thanks, @dvagnero .
I updated the content based on your feedback.
|
Suggestion: we could add a link to the Java docs that show how to configure security https://docs.oracle.com/en/java/javase/11/management/monitoring-and-management-using-jmx-technology.html#GUID-F08985BB-629A-4FBF-A0CB-8762DF7590E0 |
|
This could be a good idea, but referring to external docs in our downstream docs might have legal issues. I don't see any issue with the upstream referral, but downstream maybe. @dvagnero , would you usually refer to external docs in this instance? |
|
We already link to external doc sources (e.g. JDK Javadocs) |
|
Thanks, @tristantarrant . I provided the link in the context of the upstream docs. Downstream might be trickier, so I added an if-def statement. I hope this is OK? |
JIRA: https://issues.redhat.com/browse/ISPN-13981