ISPN-14100 REST keys operation cache value should match all #10275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should I open another JIRA for the string escape? |
wburns
reviewed
Sep 7, 2022
| @@ -361,7 +362,7 @@ private CompletionStage<RestResponse> streamKeys(RestRequest request) { | |||
| int batch = batchParam == null || batchParam.isEmpty() ? STREAM_BATCH_SIZE : Integer.parseInt(batchParam); | |||
| int limit = limitParam == null || limitParam.isEmpty() ? -1 : Integer.parseInt(limitParam); | |||
|
|
|||
| Cache<?, ?> cache = invocationHelper.getRestCacheManager().getCache(cacheName, TEXT_PLAIN, TEXT_PLAIN, request); | |||
| Cache<?, ?> cache = invocationHelper.getRestCacheManager().getCache(cacheName, TEXT_PLAIN, MATCH_ALL, request); | |||
There was a problem hiding this comment.
So the test still passes if I revert this. Maybe something missing?
There was a problem hiding this comment.
Yeah, with the TEXT_PLAIN matcher it works as expected, the only operation we do with the returned cache is over the keys. I've changed this mostly to be clear that values with any type are ok. I can revert it.
|
Merged, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/ISPN-14100
Instead of using
TEXT_PLAINto retrieve a cache, which, IIUC converts the values, we useMATCH_ALL. Also adding a test with different media-types and minor fix in the string escape.