Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13.0.x] SIFS fixes #10295

Merged
merged 3 commits into from Sep 12, 2022
Merged

Conversation

* Make sure numRecords is always updated
* Drop index has previous file to ensure count update
* Added more logging around visibility of which key is which for the
  index messages
@wburns wburns added the Backport label Sep 7, 2022
@wburns
Copy link
Member Author

wburns commented Sep 7, 2022

There are other changes I would like to backport, but unfortunately they are heavily conflicted with the segmentation improvements so I just backported manually the easier ones, including the fix for the NPE.

@tristantarrant
Copy link
Member

Some SIFS-related failures

@wburns
Copy link
Member Author

wburns commented Sep 8, 2022

testParallelIterationWithoutValue – org.infinispan.persistence.SoftIndexFileStoreParallelIterationTest was fixed in ISPN-13387

@wburns
Copy link
Member Author

wburns commented Sep 8, 2022

I can try to cherry pick ISPN-13387 to see if it goes in easily enough.

…ionWithoutValue random failures

* SIFS may return value or metadata even when not requested if
  initialized
@wburns
Copy link
Member Author

wburns commented Sep 8, 2022

Updated to include fix for the unrelated SIFS failure

@tristantarrant tristantarrant merged commit bc4974f into infinispan:13.0.x Sep 12, 2022
@tristantarrant
Copy link
Member

Merged, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants