Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISPN-14158 Add --enable-preview when running on JDK 19 #10333

Merged
merged 1 commit into from Sep 28, 2022
Merged

ISPN-14158 Add --enable-preview when running on JDK 19 #10333

merged 1 commit into from Sep 28, 2022

Conversation

tristantarrant
Copy link
Member

@tristantarrant
Copy link
Member Author

@pruivo are you using common.sh for the gossip router launcher ?

@pruivo
Copy link
Member

pruivo commented Sep 21, 2022

no, I'm not.

@tristantarrant tristantarrant added this to the 14.0.0.Final milestone Sep 26, 2022
wburns
wburns approved these changes Sep 27, 2022
View reviewed changes
Copy link
Member

@wburns wburns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, confirmed the version was properly set to the variable when doing it in my shell.

However, CI seems to have died horribly. Rerunning it to see if it was a fluke.

@ryanemerson ryanemerson merged commit 43cf8cf into infinispan:main Sep 28, 2022
@ryanemerson
Copy link
Contributor

Thanks @tristantarrant

@tristantarrant tristantarrant deleted the ISPN-14158/jdk19-enable-preview branch April 12, 2023 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wburns wburns wburns approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@tristantarrant @pruivo @ryanemerson @wburns