ISPN-14144 Propagate subject in task execution

[tristantarrant]

https://issues.redhat.com/browse/ISPN-14144

Properly fix this

[ryanemerson]

Why do we need the transient keyword, the class isn't Serializable and doesn't need to be.

[tristantarrant]

I know, but it is a nice way to mark the fields

[ryanemerson]

The correct way to handle this is to use a new field. Ideally we would just be able to add @ProtoReservice(value=3) to the class and proto.lock checks would pass. However, the reserved statement is currently commented due to a limitation in the protostream proto parser infinispan/protostream#174.

Adding @ProtoReservice(value=3) will still prevent the field being used in the ProtoField though.

A workaround to keep proto compatibility would be todo the following:

   @ProtoField(1)
   final String taskName;

   @ProtoField(2)
   final String cacheName;

   @ProtoField(number = 3, collectionImplementation = ArrayList.class)
   List<TaskParameter> parameters;

   @ProtoField(4)
   final TaskContext context;

   @ProtoFactory
   DistributedServerTask(String taskName, String cacheName, List<TaskParameter> parameters, TaskContext context) {
      this(taskName, cacheName, context);
   }
   
   public DistributedServerTask(String taskName, String cacheName, TaskContext context) {
      this.cacheName = cacheName;
      this.taskName = taskName;
      this.context = context;
   }

[tristantarrant]

This is for internal invocation only, so I'm not fussed about losing backwards compat.

[ryanemerson]

ScriptingTest and ScriptingDataStoresTest are both failing.

[tristantarrant]

Should be fixed. The AuthorizationCertIT failures made me discover that we were adding an anonymous principal to the subject when using client cert authentication. I've fixed that.

[ryanemerson]

Thanks @tristantarrant