ISPN-14163 Make SQL schema configuration builder fluent #10338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jabolina
reviewed
Sep 22, 2022
|
|
||
| public class SchemaJdbcConfigurationBuilder implements Builder<SchemaJdbcConfiguration> { | ||
| public class SchemaJdbcConfigurationBuilder<S extends AbstractJdbcStoreConfigurationBuilder<?, S>> extends AbstractJdbcStoreConfigurationChildBuilder<S> implements Builder<SchemaJdbcConfiguration> { |
There was a problem hiding this comment.
Should we do the same on QueriesJdbcStoreConfigurationBuilder?
tristantarrant
force-pushed
the
ISPN-14163/sql_schema_builder
branch
2 times, most recently
from
5009109
to
8b2d2fc
Compare
|
We have some failures. |
tristantarrant
force-pushed
the
ISPN-14163/sql_schema_builder
branch
from
8b2d2fc
to
52fbfb8
Compare
jabolina
approved these changes
Sep 26, 2022
|
Merged, thanks @tristantarrant |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/ISPN-14163